invalidate email silent failure

[Jason Etheridge]

Invalidating an email from the patron editor attempts to create a standing penalty with a note that fails under the new consolidated notes regime.

The code is in BadContact.pm, with $usr_penalty->note($_->$contact_type);

One option is to use the open-ils.actor.user.penalty.apply method instead of hand-creating the object.

[Andrea Neiman (aneiman)]

Confirmed in 3.8 as a likely consequence of bug 1846354

[Jason Etheridge (phasefx)]

I have a fix at collab/phasefx/lp1950826-invalidate-email

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1950826-invalidate-email

However, I think it perpetuates another bug where the patron editor doesn't properly handle error conditions (though those are hard to simulate, say, with Operator Change and missing permissions).

[Jason Etheridge (phasefx)]

I force-pushed a new branch that uses simplereq instead of method_lookup. I'll open a separate bug for error handling in the patron editor.

[Terran McCanna (tmccanna)]

This works for me for both invalidating email & daytime phone. Thanks!

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1950826-invalidate-email-signoff

[Bill Erickson (berick)]

New branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1950826-invalidate-penalty-fix

1. Includes sign offs for Jason's commit.

2. Adds one more commit to tweak which data is returned to the caller in the case of a penalty creation failure.

[Christine Burns (christine-burns)]

I have tested this code and consent to signing off on it with my name, Christine Burns, and my email address, <email address hidden>

[Bill Erickson (berick)]

Merged to 3.7 and up. Thanks, all!