Angular catalog search not respecting simple selector sort

Bug #1950518 reported by Llewellyn Marshall
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Undecided
Unassigned

Bug Description

Evergreen version 3.7.2

On the original catalog, the advanced search pane's "Search Filters" would group the coded values by their "is_simple" boolean value. This features has not carried over into the Angular catalog. For example, in the original catalog we had Audiobook, Book, Music, and Video appear at the top of our "Item Types" search filter using the simple selector. In the Angular catalog, all of the item types are ungrouped and sorted alphabetically.

Revision history for this message
Llewellyn Marshall (lbmarshallv) wrote :

I've created a patch on the working repository to address this bug:
user/lew/lp-1950518-simple-sort-angularized

Michele Morgan (mmorgan)
tags: added: pullrequest staffcatalog
Revision history for this message
Blake GH (bmagic) wrote :

Can't merge on master at the moment.

tags: added: needswork
removed: pullrequest
Revision history for this message
Llewellyn Marshall (lbmarshallv) wrote :

Created new branch off of Master:

user/lew/lp-1950518-simple-sort-master-fix

Looks like this issue had been partially addressed in a later update and that caused a merge conflict. This patch mirrors the initial implementation of the simple sort from the traditional catalog including the empty option in the drop down between simple sort and regular CCVMs.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Christine Morgan (cmorgan-z) wrote :

Tested on bugsquash.mobiusconsortium.org
I set 3 search formats as simple selectors. All 3 grouped at the top of the format dropdown, sorted alphabetically. The divider that is currently used in the traditional catalog to separate simple selectors from all other values, is missing. It's not clear to me if the "empty option" refers to this divider or something else. Personally, I find the divider helpful. Also tested setting 2 languages as simple selectors with the same result. Selected values grouped and sorted appropriately at the top but without a divider.

Looking at the Bootstrap catalog, simple selectors are not grouping at the top. They do currently in 3.7.2. It's not clear to me if this regression is due to this patch or something else.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.