Current Hold Groups table in Bootstrap Opac needs formatting

Bug #1950345 reported by Garry Collum
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.8
Fix Released
Medium
Unassigned

Bug Description

The Current Hold Groups table in the Bootstrap Opac does not contain cell padding so the data in each cell runs together. This table should probably be formatted in a similar fashion to the patron messages, or current charges table for consistency.

Also this table's id is the same as the Hold's History table's id, so when viewing on smaller screens the Hold Groups table's headings become Cover, Title, Author, as opposed to Name, Description, Actions.

To confirm:
Create a couple of hold groups and add a patron to each group.
Login to the Bootstrap opac using that patron's credentials to view their current holds groups.

Revision history for this message
Garry Collum (gcollum) wrote :
tags: added: pullrequest
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

Hold groups look much better and headings text doesn't change on smaller screens.

The only minor issue is when viewed on a mobile device the table repeats for each hold group and the headings aren't bolded so there's no contrast between the headings and the values for the hold groups. The headings look bolded when viewed on a computer.

Revision history for this message
Gina Monti (gmonti90) wrote :

I, Gina Monti, sign off on this bug. Padding is now available for the tables.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Jennifer - do you think your comment in #2 warrants a separate bug report?

tags: added: signedoff
Revision history for this message
Garry Collum (gcollum) wrote :

I opened another bug and assigned myself. https://bugs.launchpad.net/evergreen/+bug/1965756

It also displays incorrect column headers on smallish screens.

Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.8.1
Changed in evergreen:
milestone: 3.8.1 → none
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Garry, Jennifer, and Gina. Pushed to 3.8 and above. I did not backport to 3.7 because it is not a security fix.

Changed in evergreen:
importance: Undecided → Medium
status: Confirmed → Fix Committed
milestone: none → 3.9.1
no longer affects: evergreen/3.7
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.