Circulation Limit Set interface missing sorting, filters, and back button

[Jennifer Pringle]

Evergreen 3.7.0 and 3.7+ (tested on a bug squashing server ahead of 3.8)

The angularized Circulation Limit Set interface does not currently have filters or the ability to sort by any columns. (Administration -> Local Administration -> Circulation Limit Sets)

[Jennifer Pringle (jpringle-u)]

Confirmed still an issue in 3.8.0

[Michele Morgan (mmorgan)]

Confirmed in 3.7.2

[Jennifer Pringle (jpringle-u)]

For anyone who has lots of limit sets like us a workaround is to go back to the dojo interface anytime you need to edit the limits which you can do by going to YOURHOSTNAME/eg/staff/admin/local/config/circ_limit_set

[Erica Rohlfs (erohlfs)]

Noting that the lack of filter / sorting is particularly problematic with the introduction of the new "Edit Linked Entities" tab. The "linked entities" cannot be created at the same time as the initial limit set creation (the options to add the circ mods, locations, groups are not available during the initial New Circulation Limit Set creation). This means that the user must create the limit set (name, max items, owning library), save, and then the user must search through the list of limit sets to edit the limit set and continue building it with the "linked entities."

[Erica Rohlfs (erohlfs)]

Also noting that, if the user deletes a limit set, you'll be taken back to the start of the limit set listing. If you edit an existing limit set, clicking Save does not return you back to the limit sets. If you use the Back button, EG takes you back to the start of the limit set listing.

[Jennifer Pringle (jpringle-u)]

Confirmed this is still an issue in 3.9

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1945385-sort-and-filter-circ-limit-sets adds sorting and filtering to the circ limit sets UI by refactoring it use eg-admin-page (following the example of bug 1843970):

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1945385-sort-and-filter-circ-limit-sets

Note there's a problem with Linked Shelving Locations which is not addressed by this branch - see bug 1956358.

[Jennifer Pringle (jpringle-u)]

I've tested this fix on Jeff's server and it works well for me. I am not signing off since it should be tested by someone from another organization first.

[Jennifer Pringle (jpringle-u)]

Signing off as per discussion in irc

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

[Jason Stephenson (jstephenson)]

I tested the fix on Evergreen 3.7.3 and 3.8/master with production data, and it works for me.

I pushed it with Jennifer's signoff added to master, rel_3_9, rel_3_8, and rel_3_7.

Thanks, Jeff, Jennifer, Erica, and Michele!

[Jason Stephenson (jstephenson)]

Despite my "testing" this fix on 3.7.3, it doesn't actually work or apply to 3.7. Because of the way that I built the code, I missed the error that occurs when building the Angular staff client (Open-ILS/src/eg2) with the --prod option.

I have set this to "Won't Fix" for 3.7 and removed the 3.7.4 milestone.