Inconsistent placement of OK/confirm buttons

[Lindsay Stratton]

3.6.4, Chrome

When deleting last copies, I have noticed that the placement of the action/OK/Confirm buttons is inconsistent between the Delete Holdings dialog and the Item could not be deleted Override.

Delete Holdings dialog - Cancel is on the left and Delete Holdings is on the right
Item could not be deleted Override - Confirm is on the left and Cancel is on the right

This is really annoying when working through a long list of items.

[Dan Briem (dbriem)]

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=b7addc83a1555b3891903a4e00141e9a7c4e8dd8

It switches the cancel button to the end so that it's consistent with the confirmation dialog.

[Jennifer Weston (jweston)]

Tested on terran-testbox

The labels are changed in one scenario but not another.

The placement is now consistent if you are deleting items from either an Item Bucket or Item Status.
If you are deleting items from the Holdings View, they are still reversed: Delete confirmation, cancel in on left; Cannot be deleted, cancel is on the right. The delete confirmation from Holdings View needs to be changed to move cancel to the right to reflect the positioning of the other dialog boxes.

Attaching screen shot.

[Dan Briem (dbriem)]

Thank you for taking a look at it, Jennifer.

This branch should only affect the last one in your screen shot that doesn't line up. I just tested it on terran-testbox and my own server and it lined up. Maybe it wasn't applied when you tested it or I'm doing something different.

Also, I just noticed this issue may come up with other Angular dialog boxes, too. Generic dialogs that have OK/Confirm tend to display Cancel last. But, when there's a specific action, like Delete or Transfer, it tends to display Cancel first. But, that probably should be a separate bug.

[Jennifer Weston (jweston)]

Hi Dan,
Retested and today it works just fine. Documenting my steps this time for that last scenario that was not like the others yesterday.

On terran-textbox
From Holdings View, Actions for Selected Rows > Delete Items
Example TCN: 215, Item Barcode (checked out) = FIC490001
Cancel button for Delete Holdings confirmation is now on the correct side to match all others.
Attaching new screenshot to confirm.

I have tested this code and consent to signing off on it with my name, Jennifer Weston and my email address, <email address hidden>

[Galen Charlton (gmc)]

Pushed down to rel_3_9. Thanks, Dan and Jennifer!