marc_stream_importer.pl can fail to create the temp file depending on how it is run

Bug #1943634 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.8
Fix Released
Undecided
Unassigned
3.9
Fix Released
Undecided
Unassigned

Bug Description

Evergreen version: 3.5.3, but all affected
OpenSRF version: N/A
Postgresql version: N/A
Linux distro: N/A

Because marc_stream_importer.pl uses $0 when generating a temp file name, it can fail to create a temp file if it is started using the full path to the executable, i.e. /openils/bin/marc_stream_importer.pl.

This branch modifies the temp file creation to use the basename of the executable file rather than $0:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1943634-marc_stream_importer_temp_basename

Tags: pullrequest
description: updated
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.8-beta
Changed in evergreen:
milestone: 3.8-beta → 3.7.2
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
no longer affects: evergreen/3.6
Changed in evergreen:
milestone: 3.7.3 → none
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I targeted this at 3.10-beta to hopefully get some eyes on it. It should be backproted to 3.8 and 3.9 as well.

CW MARS have been using this patch in production on 3.7 for the past year with no ill effects.

Changed in evergreen:
milestone: none → 3.10-beta
Changed in evergreen:
importance: Undecided → Medium
Changed in evergreen:
milestone: 3.10-beta → 3.10-rc
Changed in evergreen:
milestone: 3.10-rc → 3.10.0
Revision history for this message
Jason Boyer (jboyer) wrote :

Works for me, pushed to master/3.10, rel_3_9, and rel_3_8.

Thanks Jason!

Changed in evergreen:
status: New → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
milestone: 3.10.0 → 3.10.1
status: Fix Released → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.