Default carousel spacing is too small

Bug #1940962 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Galen Charlton

Bug Description

The default carousel width is only 40% of the page width regardless of how large your browser may be. There's a place for negative space and etc., etc. but that's a bit much. Especially now that we have multiple size options for narrow widths the default should probably be 80% wide, especially if you increase the number of titles to 6-8 or so. Branch incoming.

Revision history for this message
Jason Boyer (jboyer) wrote :
Revision history for this message
Jason Boyer (jboyer) wrote :

Basic branch is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1940962_carousel_width / working/user/jboyer/lp1940962_carousel_width

Obviously this kind of thing can be customized to everyone's preference, but there is value in the defaults being more attractive.

Jason Boyer (jboyer)
tags: added: pullrequest
tags: added: carousel
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Hello, just tested this on https://terran-master.gapines.org/eg/opac/home on 9/22/2021.

Created a manual carousel with a few books with cover art. Set it up as a CONS visible carousel and it showed up in the catalog default page.

I see 5 images, that take up ~80% of the page width. So this change seems to do what it says.

Attached is a screenshot of what it looks like for me.

I have tested this code and consent to signing off on it with my name,
Josh Stompro and my email address, <email address hidden>.

Josh

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed for inclusion in 3.8. Thanks, Jason and Josh!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
milestone: none → 3.8-beta
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.