AngularJS patron record user settings - cannot remove default hold pickup location

[Lindsay Stratton]

In 3.6.4 I have found that once a patron record has had a default hold pickup location set, it cannot be cleared. It can only be replaced with another library.

This is considerable issue in our consortia, where patrons visit multiple libraries and have the expectation that a hold placed by staff at a specific library will be set to be picked up at the library. This was the behavior prior to 3.6 upgrade. Being able to remove a default pickup location would mitigate problems caused when patrons have a default set, but do not necessarily want or need a default pickup location.

Steps to test:

1. Retrieve patron record with a saved default pickup location
2. Clear the default
3. Save record
4. Default location remains unchanged

From OPAC / My Account - it is not possible to clear the default at all.

[Michele Morgan (mmorgan)]

Marking this Confirmed.

This issue also came up yesterday in our consortium. The user setting can only be UN-set by removing the row for that user for the setting type opac.default_pickup_location from the actor.usr_setting table.

I'm also linking to related bug 1759382, which proposes an org unit setting to default the pickup location for staff placed holds to the staff workstation library even if the patron has a preferred pickup location set.

[Galen Charlton (gmc)]

Updated title of the bug, as this affects the AngularJS patron editor. (The experimental Angular one does let you clear the default pickup library, although there's some squirreliness with the Angular OU selector where you have to _click_ away from the selector if you have just cleared the value).

The root cause in the the AngularJS org selector, where the function that fires the onchange handler can't distinguish between the selector not being ready yet and the user intentionally clearing a selection.

Rather than fight eg-org-selector, I think the simplest thing to do would be to add a "Clear" button next to the default pickup library selector.

[Galen Charlton (gmc)]

A patch to do exactly that is available in user/gmcharlt/lp1939154_allow_clearing_default_pickup_lib / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1939154_allow_clearing_default_pickup_lib

[Jane Sandberg (sandbergja)]

Thanks, Galen! Works well, I like the solution of adding a new button. Signoff at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1939154_allow_clearing_default_pickup_lib-signoff

[Jason Boyer (jboyer)]

Does the thing, pushed to main, rel_3_12, and rel_3_11. Thanks Galen and Jane!