Block Renews For Holds and Hold/Copy Ratio Treat Hold Shelf Differently

[Ryan Eby]

Found it in 3.5.3 but believe it is still how it works in the latest git. Probably by design.

When using the circ.block_renews_for_holds library settings open-ils.storage.action.hold_request.nearest_hold is used to determine if there is a hold that would block it. This function excludes holds that are on the hold shelf or on their way there (capture_time is null).

The hold/copy ratio logic appears to be in the database and use action.copy_related_hold_stats which looks at the action.hold_copy_map table. From looking elsewhere in the code and commits this appears to only be cleared when a hold is fulfilled, canceled, cleared. A record remains while an item is on the hold shelf.

Our original assumption was that the ratio would work similar to the block renews library option where only outstanding (not captured) holds would count against the ratio. I'm guessing others might as well.

[Lindsay Stratton (lstratton)]

This behavior is still present in 3.10.

Other hold statuses that still count as blocking renewals appear to be suspended and in transit.

When there are available copies and holds on a record, a renewal should be allowed if the holds are not waiting for item or waiting for capture.