AngularJS Add to Item Bucket Generating too many simultaneous requests

Bug #1932051 reported by Chris Sharp
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fix Released

Bug Description

Related to other AngularJS grid-related bugs, PINES has found that the action of adding a grid's items to a bucket generates enough simultaneous calls to that it maxes out those drones, sometimes resulting in the listener dropping off the network in the process.

The specific call appears to be here:;a=blob;f=Open-ILS/web/js/ui/default/staff/cat/bucket/copy/app.js;h=4216128ca1aacb83a04639885874880fe0469dbd;hb=HEAD#l262

Revision history for this message
Chris Sharp (chrissharp123) wrote :
Revision history for this message
Chris Sharp (chrissharp123) wrote :

IRC discussion with Bill E.'s confirmation of the issue and identifying additional places where these calls need attention:

Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
assignee: Chris Sharp (chrissharp123) → nobody
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1932051_fix_angjs_item_buckets contains (1) my signoff for Chris's commits, which prevent parallel requests when adding items to a bucket via the Item Buckets UI; and (2) an additional commit which serializes requests when adding to an item bucket via Item Status:;a=shortlog;h=refs/heads/user/jeffdavis/lp1932051_fix_angjs_item_buckets

Add to Item Bucket via Item Status could probably use a progress bar now, but I believe this fixes the issue.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.7.2
Revision history for this message
Chris Sharp (chrissharp123) wrote :

This works well after running in PINES production for nearly a week. Pushed to master, rel_3_6, and rel_3_7. Thanks, Jeff!

Changed in evergreen:
status: Confirmed → Fix Committed
Elaine Hardy (ehardy)
tags: added: buckets-item
removed: buckets
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers