Angularize ACQ Selection and Order Interfaces

[Bill Erickson]

Wishlist circa Evergreen 3.7

Opening this bug to track Angularization of the Acquisitions Selection and Order interfaces.

I have started working on the code and have discussed my plans with Equinox and other community members so we're not duplicating effort.

Over time, this will likely be a community project where different community members contribute needed features. My goal to start will be to implement Selection Lists, Orders, Create PO, and View/Place Orders interfaces with roughly 3/4 of the current functionality. (We don't use all of the features, so that's all I'm committing to for the moment). Of course, the end result will be to match all current functionality for these interfaces before they replace the current interfaces.

I will share my branch in progress shortly.

[Bill Erickson (berick)]

WIP:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1929741-acq-selection-order-angular

[Jane Sandberg (sandbergja)]

Thanks, Bill! Looking forward to this. Just a note that the eg-marc-simplified-editor component (currently used to create brief records in the course materials module) might be helpful for the brief records functionality.

[Bill Erickson (berick)]

Pushed a number of updates based on the recent ACQ working group session:

* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.
* Apply default lineitem order identifiers
* Indicate when multiple order identifiers exist

[Bill Erickson (berick)]

New rebased branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1929741-acq-selection-order-angular-v2

For review...

Adds and org setting and a workstation setting to 1) enable display of experimental Angular ACQ UI's and 2) enable display of links to the experimental UI's from search results.

Display a new menu entry "Acquisitions (Experimental)" when the org setting is enabled. This menu contains "Create Purchase Order" only for now.

Also displays a checkbox in the Search UI "Activate Experimental Links" which causes search result links to point to the new UI versions (e.g. link to PO).

[Tiffany Little (tslittle)]

A note from when I installed this this morning: the Acquisitions (Experimental) header and the "Activate Experimental Links" ticky box in search results were both visible before I set the library setting to enable them.

[Tiffany Little (tslittle)]

Notes from testing for a bit this morning:

- I was able to activate a completely empty PO. Neither "Allow activation with zero copy line items" or "Activate without loading items" were checked. This was just the regular "Activate" button.

- There are options in the Actions menu that shouldn't be accessible depending on the state of the PO. "Add Brief Record" should be greyed out when the PO is in any state other than 'pending.' Mark Received, Mark Unreceived, and Cancel Lineitems should be greyed out when the PO is 'pending'.
-- Because they're not, I was able to add a brief record to an on-order PO, and trying to receive something on a pending PO gives you the ugly message "Batch operation failed: ACQ_LI_RECEIVE_FAILED".

- Clicking the link for the provider in the PO should open the provider profile in another tab, not the same window/tab.

- The link for Cancel Order is always visible, even when the PO is pending. It shouldn't appear until the PO is on-order.

- When a line item is cancelled with a keep_debits=true reason (like Delayed:Backorder), the line item changes to white (it should be blue) and the line item state bubble just says 'Canceled'. It should display the whole cancel reason. If that's too long, it should at least say 'Delayed' instead of 'Canceled'.

- When I'm in the Items area, I added 2 items and hit Save Changes. If I then remove those two items but *don't* hit Save Changes again, the line item still shows a count of 2 copies no matter how many times you flip back and forth between the main PO and the Items, even though the copies are deleted. I ran into this because...

- I did not notice the Save Changes button at all for a bit because it's so far over to the right. My preference would be similar to the layout we have now, with Item Count | Field for Count | Apply and then the green Save Changes box directly to the right of it, with the Distribution Formula box below it. If others like them all on the same line, I'd at least like the green Save Changes to be aligned left so it's more obvious.

- Line Item-View History -- Audit time, expected receive time, edit time, and create time should all be timestamps.

- Acquisitions (Experimental)>Create Purchase Order -- The "Import Bibs and Create Copies" ticky should be removed, since it's not present in the current Create Purchase Order dialog and I'm not sure what it would do there anyway.

- Fields that are currently typeahead that should be dropdowns:
* Direct charges - Fund
* Items - Copy Location, Fund, Circ Mod
* Cancel Reason dialog box - Cancel Reason

UX preferences, subject to others' preferences and feasibility:

- I'd prefer that the fields in the Items batch updater and copies were not filled with the helper text. See bug 1906862.

- It would be nice if line items had a border around them, even if it was a light gray one(?) to separate them from the white of the back of the page. All of the line item colors are generally pretty pastel/light, and defining them with a border is easier on the eyes. This is especially useful when you do have canceled line items, since they're white. Without a border they just kind of look like they're floating on the page, for l...

[Ruth Frasur Davis (redavis)]

In the "Create Purchase Order" interface, the Provider field includes double-ended arrows indicating a list. This box, however, is type ahead. It would be preferable to have a prepopulated list of providers and then type ahead to narrow down in a long list.

Related, the "Provider" label is confusing since it's not drawing in the Provider Name, but rather the Provider Code.

[John Amundson (jamundson)]

Line Items
- Links for "Catalog" and "View Invoices" should open in new tabs.
- "Error Retrieving Results" when attempting to view line item history

Items
- Fund dropdown should list year and branch to match development in Acq Funds (This may already be Equinox development).
-

POs
- Deleting a line item does not update PO summary (line item count)
- A received PO status displays as blank instead of "Received"

General
- Anywhere "lineitem" is listed, update to "line item"

[Christine Morgan (cmorgan-z)]

I had the same experience as Tiffany (comment #6) with the Save Changes button. I did not see it way over on the right and left the screen without saving the items I added. A warning that you are leaving the screen without saving would be helpful in addition to Tiffany's suggestions.

+1 to Activate, Activate without Loading Items, and Cancel Order being buttons.

+1 to prepopulated dropdowns

I think the wording for the "Items in Page" and "All Items" should be "Line Items in Page and All Line Items Since Copies are now Items, it's not completely clear what those checkboxes are actually referring to.

[Ruth Frasur Davis (redavis)]

The "Import and Create Copies" seems to hang things up in the "Create Purchase Order Interface." Also verifying/agreeing with Tiffany's type ahead/drop-downs in Purchase Order interface (also elsewhere).

[Ruth Frasur Davis (redavis)]

just adding a note here - in addition to testing - to say that I'm of the understanding that there is possibility for this to be merged for release so long as major functionality persists and any wishlist/labeling considerations should not prevent that. Is this an accurate understanding?

[Christine Burns (christine-burns)]

The batch updater should be on the main PO page

Currently this is only found on the item page - this is a huge loss of fuctionality if staff have to go into each line item to assign line item attributes

[Mary Llewellyn (mllewell)]

My two cents:

I miss the "Link to catalog" indicator, which is a good reminder of the bib processing step and a clue if the loader had not included a queue name.

The worksheet doesn't show anything, in particular a note or alert on a line item.

[Christine Morgan (cmorgan-z)]

In the Create Purchase Order interface, the Ordering Agency should default to the workstation location as it currently does in the dojo interface. It would also be helpful if it were sticky for those libraries that order at the system level.

[Mary Llewellyn (mllewell)]

worksheet comparisons

[Blake GH (bmagic)]

Bill,

Probably needs a little rebasing on master:

git merge working/user/berick/lp1929741-acq-selection-order-angular-v2
Auto-merging Open-ILS/src/sql/Pg/950.data.seed-values.sql
CONFLICT (content): Merge conflict in Open-ILS/src/sql/Pg/950.data.seed-values.sql
Auto-merging Open-ILS/src/eg2/src/styles.css
CONFLICT (content): Merge conflict in Open-ILS/src/eg2/src/styles.css
Auto-merging Open-ILS/src/eg2/src/app/staff/catalog/record/actions.component.html
Auto-merging Open-ILS/src/eg2/src/app/share/item-location-select/item-location-select.component.ts
CONFLICT (content): Merge conflict in Open-ILS/src/eg2/src/app/share/item-location-select/item-location-select.component.ts
Auto-merging Open-ILS/src/eg2/src/app/share/item-location-select/item-location-select.component.html
CONFLICT (content): Merge conflict in Open-ILS/src/eg2/src/app/share/item-location-select/item-location-select.component.html
Auto-merging Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
CONFLICT (content): Merge conflict in Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
Auto-merging Open-ILS/src/eg2/src/app/share/combobox/combobox.component.html
CONFLICT (content): Merge conflict in Open-ILS/src/eg2/src/app/share/combobox/combobox.component.html
Auto-merging Open-ILS/src/eg2/src/app/share/catalog/catalog.service.ts
CONFLICT (content): Merge conflict in Open-ILS/src/eg2/src/app/share/catalog/catalog.service.ts
Auto-merging Open-ILS/examples/fm_IDL.xml
Automatic merge failed; fix conflicts and then commit the result.

[Galen Charlton (gmc)]

Noting that I've cherry-picked this (from Bill's -v3 branch) into my working branch for bug 1942220, user/gmcharlt/ang-acq-4-wip, along with Tiffany's load MARC order records branch from bug 1929749

[Terran McCanna (tmccanna)]

Marking this as a dupe of bug 1942220 since the work is being done there.