no UI for bibliographic record notes

Bug #1929242 reported by Rogan Hamby
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

There are tables and IDL entries for bib and auth record notes but they are not exposed to catalogers.

Revision history for this message
Rogan Hamby (rogan-hamby) wrote : Re: no UI bibliographic record notes

Im changing the title to bib notes as authority notes are probably of lower interest and not worth holding up bib notes for. I have a patch partially complete and hopefully will find time to wrap it up soon.

summary: - no UI for authority or bibliographic record notes
+ no UI bibliographic record notes
Changed in evergreen:
assignee: nobody → Rogan Hamby (rogan-hamby)
importance: Undecided → Low
Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Not slapping a pull request on it yet as I want to install it on a clean box and test but it works for me on my dev VM:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=8301c5a790b39ef9ac0f43fc6923aa7889f5dcbd

Revision history for this message
Jennifer Weston (jweston) wrote :

+1 to making this visible to catalogers -- thanks Rogan!

Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

added release notes: bdc8013f2c3e97e9cd54ca9b0d72bfd79e001f6f and slapping pull request on, will open a new launchpad for the public display of notes if this gets committed as I want some community input before deciding on how they will display

summary: - no UI bibliographic record notes
+ no UI for bibliographic record notes
tags: added: cataloging pullrequest
Revision history for this message
Jason Boyer (jboyer) wrote :

Hi Rogan, I went ahead and corrected it to get this loaded for feedback fest, but you're missing a comma at the end of line 1963 in 950.data.seed-values.sql that causes issues. It would be great if you could add a commit that corrects that so a committer doesn't have to catch it when pushing. Also a branch name would be helpful. :)

Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

hmmmmm no comma no bueno. hmmm I think I know what happened with the branch name and for once the problem was the keyboard and not the user. regardless ...

fix pushed to : 2ef50ed72c50e46acc77360d0663b901db998f21 user/rogan/lp1929242_bib_notes_ui with the parent commits, thanks for the eyes!

Revision history for this message
Ruth Frasur Davis (redavis) wrote :

Pardon me while I geek out just a little bit with this. That is a fantastic (!!!) feature! I've tested this code and consent to sign off on it using my name, Ruth Frasur, and email address, <email address hidden>.

This is SO cool!!

tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
assignee: Rogan Hamby (rogan-hamby) → nobody
status: New → Confirmed
importance: Low → Wishlist
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
milestone: none → 3.8-beta
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.8 along with some follow-ups:

- edit release notes
- make notes grid filterable
- remove console noise
- flesh creator and editor in the grid

Thanks, Rogan and Ruth!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.