Add an active flag to Acq cancel reasons

[Tiffany Little]

3.6.3+

Request to add an active flag to acquisitions cancel reasons. Once a cancel reason has been used, it can never be deleted. However, there are cancel reasons that we would prefer no longer showed in the available list when cancelling a line item or purchase order.

[Tiffany Little (tslittle)]

I have a branch to add an active column to cancel reasons:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP1924758_acqcr_activeflag

The main purpose of this is to exclude not broadly used cancel reasons from user drop down lists. Many of the stock cancel reasons are reserved for EDI cancelations and cannot be deleted even if they've never been used. So the list is quite long to scroll through when really maybe only 2-4 cancel reasons are ever selected by users. EDI should still be able to use a cancel reason even if it's marked as inactive, because the ID is still there.

My question is: I used "active", but is "visible" better wording? "Staff visible?"

[Galen Charlton (gmc)]

I prefer staff_visible (or maybe staff_usable, staff_applicable, manually_applicable or the like, as cancel reasons set by EDI are visible to staff when they review the PO) - "active" == false would imply that the value shouldn't be set at all.

[Mary Llewellyn (mllewell)]

The "active" box is present. Unchecking it labels it as "No" in the Active column in the list of Cancel Reasons.

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>.

[Tiffany Little (tslittle)]

Removing the signedoff tag for the moment. After polling the AIG meeting today, I'm going to update my branch to use "staff_visible" instead of "active."

[Jane Sandberg (sandbergja)]

Thanks, Tiffany! Removing pullrequest and milestone for the moment while you're working on using "staff_visible".