Angular Staff Catalog: Place Hold screen should use preferred name

Bug #1924621 reported by Terran McCanna
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.6
Fix Released
Undecided
Unassigned

Bug Description

In 3.6.2:

The Angular Staff Catalog's "Place Hold" screen displays the patron's name when a patron barcode is entered, but it should use the preferred name when one is specified.

See also: https://bugs.launchpad.net/evergreen/+bug/1924185

Revision history for this message
Garry Collum (gcollum) wrote :
Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Michele Morgan (mmorgan)
tags: added: holds staffcatalog
Revision history for this message
Mary Llewellyn (mllewell) wrote :

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
tags: added: signedoff
Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: none → 3.7.2
Revision history for this message
Bill Erickson (berick) wrote :

Here's a follow up branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1924621-hold-for-use-pref-name

1. Adds sign-off's to Gary's patch.

2. Adds a second patch to display the pref name in the banner along the top of the catalog page, "Placing hold for <patron pref name>". (Accessed from patron search -> select patron -> holds -> place hold).

Without the second patch, a scenario arises where 2 variations of the patron name are displayed on the same interface, which is confusing.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
tags: removed: signedoff
Revision history for this message
Gina Monti (gmonti90) wrote :

I, Gina Monti, sign off on this. Preferred name shows up when placing a hold in Angular catalog.

tags: added: signedoff
Jason Boyer (jboyer)
Changed in evergreen:
assignee: nobody → Jason Boyer (jboyer)
Revision history for this message
Jason Boyer (jboyer) wrote :

Pushed to master, rel_3_7 and rel_3_6 with a squashed swap to Bill's followup. Thanks everyone!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Jason Boyer (jboyer) → nobody
tags: added: circ-holds
removed: holds
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.