Button in Patron Messages interface in OPAC are not translatable

[Eva Cerninakova]

The "Mark Read", "Mark Unread" and "Delete" buttons in Patron Messages interface (Open-ILS/src/templates-bootstrap/opac/myopac/messages/list.tt2, lines 67-69) are not marked for translation

The correct contents of the lines 67-69 should be:

                <button name="action" class="btn btn-action" value="mark_read" id="mark_read" type="submit"><i class="fas fa-glasses" aria-hidden="true"></i> [% l('Mark Read') %]</button>
                <button name="action" class="btn btn-opac" value="mark_unread" id="mark_unread" type="submit"><i class="fas fa-eye-slash" aria-hidden="true"></i> [% l('Mark Unread') %]</button>
                <button name="action" class="btn btn-deny" value="mark_deleted" id="mark_deleted" type="submit" onclick="return confirm('[% l("Are you sure you wish to permanently delete the selected message(s)?") %]')"><i class="fas fa-trash-alt" aria-hidden="true"></i> [% l('Delete') %]</button>

[Steven Mayo (stmayo)]

Pushed this change at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=dc7b09b30d9e66281d8296c21e7425a0399d0ac3

(Woo! my first commit!)

[Terran McCanna (tmccanna)]

I'm getting an error following the link in comment #1, but this one should work:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp1919501-patron_messages_button_translateable

[Eva Cerninakova (ece)]

I tested the bug using https://terran-testbox.gapines.org/. I can confirm that buttons appear translated in cases when the translation of the button text is available in the system (In Czech the translation for the "Mark read" is missing, however, in Spanish all buttons appeared translated).

I consent to signing off on it with my name, Eva Cerniňáková and my email address, <email address hidden>.

[Terran McCanna (tmccanna)]

Thanks Steven and Eva!

Fix committed and pushed back as far as 3.10