Angular grids with >100 entries cuts off row number

Bug #1916754 reported by Tiffany Little
46
This bug affects 10 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

In the new Angular grids, if you have 100 or more rows, the row number gets clipped off after the first digit. See screenshots. That column should either expand to fit the value, or we should be able to shrink/expand that column the same as the others.

Revision history for this message
Tiffany Little (tslittle) wrote :
Revision history for this message
Tiffany Little (tslittle) wrote :
Changed in evergreen:
importance: Undecided → Low
Garry Collum (gcollum)
Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Here's a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1916754-grid-row-numbers-over-100

This patch accommodates 3-digit numbers but not 4-digit numbers. I wasn't sure if that use case was common enough to warrant carving out the space.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.7.2
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

Showing 3 digits is a huge improvement. I'm willing to sign off on that and then we can wait and see if a need to extend it to 4 presents itself in the future.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1916754-grid-row-numbers-over-100-signoff

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_7. Thanks, Bill and Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.