Add test / check outputs to gitignore

Bug #1915816 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Affects all supported versions of Evergreen.

Having run make check a few times there are some things we should add to the project .gitignore:
Open-ILS/src/c-apps/tests/check_idl.log
Open-ILS/src/c-apps/tests/check_idl.trs
Open-ILS/src/c-apps/tests/check_util.log
Open-ILS/src/c-apps/tests/check_util.trs
Open-ILS/src/c-apps/tests/test-suite.log

And some build artifacts:
Open-ILS/web/opac/deps/node_modules/
node-v12.13.0-linux-x64.tar.xz

And then there's this guy:
Open-ILS/web/js/ui/default/staff/package-lock.json

Which according to node docs we should add to git and track like we do with the eg2 version.

Branch en route.

Revision history for this message
Jason Boyer (jboyer) wrote :

Here's a branch with 2 commits: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1915816_more_ignore / working/user/jboyer/lp1915816_more_ignore

The first adds the test outputs and so on mentioned above, while the tip removes a few things that we don't appear to be capable of generating anymore anyway. I'm less concerned about that.

Revision history for this message
Shula Link (slink-g) wrote :

Confirmed that the listed documents are not included in .gitignore.

Might I also suggest Open-ILS/src/edi_translator/data/test_output as an addition? I'm not sure we need to track .tmp files

Thanks,
Shula

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :

I've taken the liberty of adding the pullrequest tag so this can get more eyes on it

tags: added: cleanup pullrequest
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thank you, Jason and Shula! Pushed to master, along with Shula's suggested addition and an update to package-lock.json.

Changed in evergreen:
milestone: none → 3.9-rc
importance: Undecided → Medium
Changed in evergreen:
status: Confirmed → Fix Committed
tags: added: signedoff
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers