Angular form field order: Hold Policies

[Michele Morgan]

A followup to bug 1857351 where the field order of many angular forms was addressed.

Further discussion was needed on the field order in the Hold Policies page. Given the large number of "cause and effect" type fields, it would be helpful to put some thought into a sensible order.

Suggestions from the initial report:

Hold Policies
This one has so many fields, I think it would be helpful to put the Description field first and then to break it up visually into natural groups of fields related to related to a) item, b) user, c) holds (or something along those lines).

[Terran McCanna (tmccanna)]

Proposed patch at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1915464_hold_policies_field_order

I wasn't able to figure out a way to add visual breaks in the modal, but the new order is roughly
Description - Active - Owning & Circ Libs - Record & Item Info - User Info - Hold Info - Transit Info.

[Stephanie Leary (stephanieleary)]

Terran, that sounded like a challenge, so I fiddled with the fieldmapper editor to add a way to group things. I just did one as an example; you'll need to add the rest:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1915464_hold_policies_field_order_group_styling

(Also my signoff on your branch!)

[Terran McCanna (tmccanna)]

Awesome, thanks, Stephanie! I've signed off on your commit and added another to add a little more styling and apply to the top row of each main group. (Now a little more top-padding space and also a dotted line.) Top 3 commits at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1915464_hold_policies_field_order_plus

One issue I'm having is that some of the rows I try to apply it to are not recognizing the new styling and I'm not sure why. In this latest version it should be applying the styling to item_owning_ou, user_home_ou, holdable, and requestor_grp but it's ignoring requestor_grp for some reason.

[Terran McCanna (tmccanna)]

Teamwork makes the dreamwork - the final (hopefully) version of mine and Stephanie's combined efforts is in the top 2 commits at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1915464_hold_policies_field_order_squashed

Screenshot of the new group styling attached (adds a dotted line and extra space at the top of each logical field group).

[Michele Morgan (mmorgan)]

This looks great! The groupings make sense and it flows much more smoothly.

Here is my signoff branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1915464_signoff

Thanks for your work Terran and Stephanie!

[Michele Morgan (mmorgan)]

Adding before and after screenshots of the modal for good measure.

Here's the before:

[Michele Morgan (mmorgan)]

And here's the much improved after.

[Jane Sandberg (sandbergja)]

Thanks, Terran, Stephanie, and Michele. Pushed to rel_3_12 and main, along with a lil follow-up to use spaces rather than tabs, and remove an extra comma.