Hopeless Holds: hopeless_date should be cleared when hold is captured

[Michele Morgan]

Evergreen 3.6.1

It's not uncommon for a hopeless hold to be captured should the hopeless situation be resolve, for example, should a missing item get checked in.

When that happens, the hold retains its hopeless_date and still appears on the Hopeless Holds report. We have seen Ready for pickup holds appearing on the Hopeless Holds report.

[Bill Erickson (berick)]

Just found this happening for us today. Patch in progress.

[Bill Erickson (berick)]

Fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1915440-clear-hopeless-date-on-capture

To test:

. Configure the Missing copy status as holdable=true hopeless_prone=true
. Place hold with only 1 viable copy.
. Mark said copy as missing -- this stamps a hopeless_date on the hold.
. Check the copy in. This results in a captured + hopeless hold.

Repeat with patch and the hopeless date is cleared when the hold is captured.

[Susan Morrison (smorrison425)]

Followed steps above on multiple items and confirmed all were removed from Hopeless Holds and the Hopeless Date cleared after checkin.

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

[Galen Charlton (gmc)]

Pushed down to rel_3_8. Thanks, Bill and Susan!