Hopeless Holds: hopeless_date should be cleared when hold is captured

Bug #1915440 reported by Michele Morgan
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
3.8
Fix Committed
Medium
Unassigned
3.9
Fix Committed
Medium
Unassigned

Bug Description

Evergreen 3.6.1

It's not uncommon for a hopeless hold to be captured should the hopeless situation be resolve, for example, should a missing item get checked in.

When that happens, the hold retains its hopeless_date and still appears on the Hopeless Holds report. We have seen Ready for pickup holds appearing on the Hopeless Holds report.

Dan Briem (dbriem)
tags: added: circ-holds
removed: holds
Revision history for this message
Bill Erickson (berick) wrote :

Just found this happening for us today. Patch in progress.

Changed in evergreen:
status: New → Confirmed
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1915440-clear-hopeless-date-on-capture

To test:

. Configure the Missing copy status as holdable=true hopeless_prone=true
. Place hold with only 1 viable copy.
. Mark said copy as missing -- this stamps a hopeless_date on the hold.
. Check the copy in. This results in a captured + hopeless hold.

Repeat with patch and the hopeless date is cleared when the hold is captured.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.9.1
assignee: Bill Erickson (berick) → nobody
tags: added: needsrebase
tags: removed: needsrebase
Revision history for this message
Susan Morrison (smorrison425) wrote :

Followed steps above on multiple items and confirmed all were removed from Hopeless Holds and the Hopeless Date cleared after checkin.

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
milestone: 3.9.1 → 3.9.2
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_8. Thanks, Bill and Susan!

Changed in evergreen:
milestone: 3.9.2 → 3.10.1
importance: Undecided → Medium
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers