Staff Client eg grid not sorting alphabetically

[Llewellyn Marshall]

Version: Evergreen 3.5.1
Browser: tested in Firefox & Chrome

When sorting by text columns in the AngularJS staff client, we found that records in all caps were sorted above lowercase records. This was confusing to catalogers trying to look at holds on a very popular record. They'd assumed that records in all caps would be treated the same as lower case strings and intermixed within them. I found that the comparator for the data in the grid service was using the same comparison function regardless of type.

I've created a code patch that addresses this issue by utilizing different comparator functions based on the type of the data. For strings, the data is compared while lower case.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/NC22753-eg-grid-string-sort

[Cheryl Middleton (cheryl-middleton)]

 Pushing this code patch to production solved the issue we were experiencing when attempting to sort large numbers of holds on catalog records - sorting alphabetically by patron name to determine as closely as possible specific patron's position in the queue

[Garry Collum (gcollum)]

I tested by changing some titles in the concerto database to lower case and then sorted in a patron's items out and hold's list. The patch works perfectly. A signed-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/LP1912840-eg-grid-string-sort-signoff

[Jane Sandberg (sandbergja)]

Thanks for the patch, Llewellyn, and for the testing, Garry. I was about to push it, but noticed:

1. The commit is missing your signoff, Llewellyn.
2. The commit doesn't include the LP number in the commit message.
3. There is still a console.log debugger line in the commit.

With your permission, Llewellyn, I can amend your commit to add the first two, and push a follow-up commit for the third item. Or, if you're up for amending this commit, that would also be great.

[Andrea Neiman (aneiman)]

removing signoff based on comment #3

[Llewellyn Marshall (lbmarshallv)]

Sign-off, LP number, removed console.log statement are all present on this new branch off of Main.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/lp1912840-eg-grid-sort

[Terran McCanna (tmccanna)]

Thanks Llewellyn & Garry! Fix merged for 3.12 and back as far as 3.10.