Default circulators permissions should include new booking reservation

[Jane Sandberg]

Bug 1835127 added two new permissions: VIEW_BOOKING_RESERVATION and VIEW_BOOKING_RESERVATION_ATTR_MAP. But the default circulator group permissions don't include these new permissions. This means that circulators can't see the Manage Reservations screen.

So that circulators can use the booking module out of the box, let's throw these permissions into grp_perm_map at the Branch level.

Branch forthcoming.

[Jane Sandberg (sandbergja)]

Branch at user/sandbergja/lp1910891_booking_perms_to_appropriate_groups

Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1910891_booking_perms_to_appropriate_groups

Testing notes from the commit message:

1) Without this patch, create a reservation for a BR1 resource at BR1.
2) Log in as a circulator at BR1.
3) Go to Booking > Manage Reservations. Note that you can't see your reservation.
4) Run this upgrade script.
5) Repeat steps 2-3. Notice that you can now see the reservation.
6) Wipe your database and re-install it with the additions to the seed data in this commit. Repeat steps 1-3 and notice that you can see the reservation as expected.

[Terran McCanna (tmccanna)]

Looks good! My sign off is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1910891_booking_perms_to_appropriate_groups_signoff

[Galen Charlton (gmc)]

Pushed to master, rel_3_7, and rel_3_6. Thanks, Jane and Terran!

[Ryan Eby (aadl-ubuntu)]

Note: The 3.5.1-3.6.0 upgrade script completely leaves out the sql to create the permissions. The 3.5.1-3.5.2 script includes it. If you went major versions you will want to run the sql in 1238.data.permission.booking_reservation.sql or you won't have the permissions for this fix.