Default circulators permissions should include new booking reservation

Bug #1910891 reported by Jane Sandberg
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Fix Released

Bug Description

Bug 1835127 added two new permissions: VIEW_BOOKING_RESERVATION and VIEW_BOOKING_RESERVATION_ATTR_MAP. But the default circulator group permissions don't include these new permissions. This means that circulators can't see the Manage Reservations screen.

So that circulators can use the booking module out of the box, let's throw these permissions into grp_perm_map at the Branch level.

Branch forthcoming.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Branch at user/sandbergja/lp1910891_booking_perms_to_appropriate_groups

Here's a link:;a=shortlog;h=refs/heads/user/sandbergja/lp1910891_booking_perms_to_appropriate_groups

Testing notes from the commit message:

1) Without this patch, create a reservation for a BR1 resource at BR1.
2) Log in as a circulator at BR1.
3) Go to Booking > Manage Reservations. Note that you can't see your reservation.
4) Run this upgrade script.
5) Repeat steps 2-3. Notice that you can now see the reservation.
6) Wipe your database and re-install it with the additions to the seed data in this commit. Repeat steps 1-3 and notice that you can see the reservation as expected.

tags: added: pullrequest
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: signedoff
Changed in evergreen:
milestone: none → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_7, and rel_3_6. Thanks, Jane and Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
Revision history for this message
Ryan Eby (aadl-ubuntu) wrote :

Note: The 3.5.1-3.6.0 upgrade script completely leaves out the sql to create the permissions. The 3.5.1-3.5.2 script includes it. If you went major versions you will want to run the sql in or you won't have the permissions for this fix.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.