Shelving locations with items attached can be deleted

[Elaine Hardy]

PINES is seeing this behavior in 3.4 and 3.6. Shelving locations with items attached can be deleted in local admin. While they remain in the list, deleted shelving locations have the deleted flag set to yes and any items with that shelving location do not show up in OPAC holding lists.

Shelving locations with active items attached should not delete.

[Michele Morgan (mmorgan)]

Confirmed in 3.6. Marking bug 1910472 as a duplicate of this, since the real problem is not one of messaging, the deletion is succeeding when it shouldn't be.

[Bill Erickson (berick)]

Here's a patch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1910546-reject-active-acpl-delete

---

Raise a database exception when any attempt is made to mark a copy location as deleted when the location contains non-deleted copies.

To Test:

1. Navigate to /eg2/staff/admin/local/asset/copy_location

2. Attempt to delete a copy location that is known to contain non-deleted copies.

3. Confirm an error message is displayed and the location is not marked as deleted.

[Tiffany Little (tslittle)]

Bill, is the error message to the user intended to display the "Copy location % contains active copies and cannot be deleted"? Or is that only for the logs? I tested this for BSW and did get the desired behavior of not deleting the shelving location, but just got a generic red toast that the action failed or was disallowed.

I just wanted to be sure what error I should be getting before signing off on it.

[Bill Erickson (berick)]

Tiffany, the error is only meant to appear in the logs.

[Tiffany Little (tslittle)]

Ok, thanks Bill!

I have tested this code and consent to signing off on it with my name, Tiffany Little and my email address, <email address hidden>.

[Michele Morgan (mmorgan)]

Pushed to master, rel_3_9 and rel_3_8.

Thanks Bill and Tiffany!