Bootstrap OPAC: Shared Lists no longer display title and description

Bug #1909584 reported by Terran McCanna
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.6
Fix Released
Low
Unassigned

Bug Description

In 3.6.1 Bootstrap OPAC:

In the previous OPAC, the title and description of a list would display in the catalog-view of a shared list. They no longer appear.

Garry Collum (gcollum)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.6.2
Revision history for this message
Garry Collum (gcollum) wrote :
tags: added: signedoff
Changed in evergreen:
importance: Undecided → Low
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Revision history for this message
Galen Charlton (gmc) wrote :

Removing signoff. There's an existing pair of CSS classes that match TPAC:

.result-bookbag-name { font-size: [% css_fonts.size_bigger %]; font-weight: bold; }
.result-bookbag-description { font-size: [% css_fonts.size_bigger %]; font-style: italic; }

I don't actually mind if we want to rename the classes to shared-list-{title,description}, but I do think we should uses the css_fonts.size_* variables in the template rather than hard-coding the font size.

tags: removed: signedoff
tags: added: needsrepatch
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks, Galen! Using the same CSS class makes sense to me, it just didn't occur to me before. New branch at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1909584_shared_list_title_and_description_2

tags: removed: needsrepatch
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Revision history for this message
Ruth Frasur Davis (redavis) wrote :

I've tested this code and consent to signing off on it using my name, Ruth Frasur, and email, <email address hidden>.

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_6. Thanks, Terran and Ruth!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.