Angular catalog: View Holds tab missing default columns

Bug #1907123 reported by Elaine Hardy on 2020-12-07
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

In the angular catalog, View holds tab for a bib record has no default column values set so no holds on the record appear until columns are chosen.

tags: added: webstaffcolumns
Revision history for this message
Terran McCanna (tmccanna) wrote :

What are the best columns to have show up as the defaults here?

Revision history for this message
Elaine Hardy (ehardy) wrote :

What I would like to see as default:

Hold ID
Patron barcode
Request date
Capture date
Hold type
Pickup library
Title
Status

Revision history for this message
Michele Morgan (mmorgan) wrote :

I am not able to confirm the lack of default columns in the Angular catalog. I see the following by default on the Angular catalog View Holds tab on a 3.6 system:

Hold ID
Current Item
Patron alias
Request Date
Capture Date
Available Date
Hold Type
Pickup Library
Potential Items
Status

I would agree that patron barcode would be more useful here than Patron alias. Also, we find Available Date is not generally worth the space as a default column.

Revision history for this message
Terran McCanna (tmccanna) wrote :

I didn't see the columns last week (same as Elaine) but I see them now, so there must have been an issue with our test server. I'm going to go ahead and mark this one Invalid since it appears to have been a local issue.

Changed in evergreen:
status: New → Invalid
Revision history for this message
Michele Morgan (mmorgan) wrote :

I'm resurrecting this bug. There are default Hold columns in the angular catalog, but our users are reporting that the grid settings frequently are lost, resulting in the blank grid. Users are frequently having to re-configure the settings.

I'm trying to pin down the actions that cause the grid settings to be lost.

Changed in evergreen:
status: Invalid → Confirmed
Elaine Hardy (ehardy) on 2021-01-22
summary: - Angular catalog: View HOlds tab missing default columns
+ Angular catalog: View Holds tab missing default columns
Revision history for this message
Michele Morgan (mmorgan) wrote :

I've tracked down the issue with the disappearing hold columns.

Custom grid configuration for the holds interfaces are stored in the workstation setting eg.grid.cat.catalog.wide_holds. This workstation setting is shared by the Traditional catalog and the Angular Staff Catalog. The values of the workstation settings for eg.grid.cat.catalog.wide_holds in the two versions of the catalog don't play well with each other.

If the user has customized the holds grid in the Traditional catalog, the Angular catalog cannot read the customizations and the Angular grid appears blank. If the user then customizes the holds columns for the Angular catalog, the Traditional catalog cannot read them and the Traditional holds grid is blank.

Here are sample values for the workstation setting eg.grid.cat.catalog.wide_holds for the same set if columns in each staff catalog:

Traditional

{"limit":25,"columns":[{"name":"hold.id"},{"name":"hold.cp_barcode"},{"name":null},{"name":"hold.request_time"},{"name":"hold.capture_time"},{"name":"hold.shelf_time"},{"name":"hold.hold_type"},{"name":"hold.pl_shortname"},{"name":"hold.potentials"}],"version":2}

Angular

{"columns":[{"name":"id"},{"name":"cp_barcode"},{"name":"usr_alias"},{"name":"request_time"},{"name":"capture_time"},{"name":"shelf_time"},{"name":"hold_type"},{"name":"pl_shortname"},{"name":"potentials"},{"name":null}],"version":2,"limit":10}

If you have not customized the holds grid, you will see the system defaults for each catalog (which are different in Angular vs. Traditional), but as soon as you save the holds grid in one catalog, you will lose the holds columns in the other.

A time-consuming headache for staff users!

Michele Morgan (mmorgan) on 2021-03-02
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

My proposed fix is to retrofit the TPAC file to use the same names for saving columns as the Angular Catalog. Working branch is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1907123_fix_missing_view_holds_columns

user/mmorgan/lp1907123_fix_missing_view_holds_columns

While working on this, I discovered that the hold status column cannot be saved in the angular catalog. See related bug 1917495.

tags: added: pullrequest
Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
milestone: none → 3.6.3
Revision history for this message
Elaine Hardy (ehardy) wrote :

Tested on https://tiffany-master.gapines.org. Placed hold and checked view holds. Default columns are set and holds are visible without additional user action.

I have tested this code and consent to signing off on it with my name, Elaine Hardy and my email address, <email address hidden>.

Changed in evergreen:
importance: Undecided → Medium
tags: added: signedoff
removed: webstaffclient
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Revision history for this message
Galen Charlton (gmc) wrote :

Noting that the patch for bug 1928684 probably means that the patron_barcode column in the this bug's patch needs to be renamed to ucard_barcode.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers