Bootstrap OPAC: Show covers for checked out items

Bug #1906855 reported by Tiffany Little
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

For the Bootstrap OPAC. Wishlist.

A wishlist item would be to show the covers for items in the Current Items Checked Out grid. It would be a plus to also add this in the Items on Checkout History/Items on Hold/Holds History screens as well.

Revision history for this message
Terran McCanna (tmccanna) wrote :

This adds cover images to items out, circ history, current holds, and holds history pages in My Account:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1906855_covers_in_my_account

tags: added: pullrequest
Revision history for this message
Garry Collum (gcollum) wrote :
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Upon review: the proposed patch adds four copies of a nearly-identical template block to generate the cover image markup. The duplication would cause maintenance difficulties if it ever needs to be tweaked or another client-side image provider is added; it should be moved to a Template Toolkit BLOCK or MACRO.

tags: added: needsrepatch
removed: pullrequest signedoff
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks, Galen. I have reworked it to be in a BLOCK and also added it to the Lists page. New patch for review is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1906855_covers_in_my_account_2

tags: added: pullrequest
removed: needsrepatch
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Revision history for this message
Mary Llewellyn (mllewell) wrote :

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
tags: added: signedoff
Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
milestone: none → 3.8-beta
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.8. Thanks, Terran, Garry, and Mary!

Changed in evergreen:
status: New → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.