When placing an unfillable hold the screen will not advance on the override if there is no items

[Steve Callender]

Tested on 3.3, 3.4, 3.5, 3.6

When placing an unfillable hold with the PLACE_UNFILLABLE_HOLD permission (may need the ITEM_NOT_HOLDABLE.override permission as well) the override will appear, but when forcing the override the screen will not advance and will remain on the override screen.

There was an earlier issue where this was fixed, but it was for if there was a potential item that was not-holdable.

This issue happens when there are absolutely no items available for the hold, such as using a pickup library that doesn't have the title and has their hard boundary set to 1.

Potential patch incoming.

Steve

[Steve Callender (stevecallender)]

Patch thanks to Mike Rylander

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=14ad739d943074b8f0db3f1b95e720bd917a0a21

[Terran McCanna (tmccanna)]

Noting that this solves the problem with the traditional staff catalog, but there is still an issue with the angular staff catalog that I suspect is in the angular logic rather than the perl logic - I'll open a separate bug for that.

My sign off for this one is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1906842_unfillable_hold_perm_fix_signoff

[Galen Charlton (gmc)]

Pushed down to rel_3_7. Thanks, Mike, Steve, and Terran!