Nesting Issues on the Bootstrap OPAC Record Detail Page

Bug #1901710 reported by Jason Boyer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.6
Fix Released
Medium
Unassigned

Bug Description

Evergreen 3.6+

There are issues with tag nesting in the Bootstrap OPAC. Some cause more issues than others, but the W3C HTML validator can help track them down.

Multiple 856 links: it appears that the END tag for the FOR that cycles through the available links is in the wrong place. Multiple links in a single record gives you HTML that looks like this:

<ul>
  <li class="rdetail_uri" property="offers" vocab="http://schema.org/" typeof="Offer">
  <a href="LINK1" class="uri_link" property="url">
  LINK1
  <li class="rdetail_uri" property="offers" vocab="http://schema.org/" typeof="Offer">
  <a href="LINK2" class="uri_link" property="url">
  LINK2
  <li class="rdetail_uri" property="offers" vocab="http://schema.org/" typeof="Offer">
  <a href="LINK3" class="uri_link" property="url">
  LINK3</a>
  <link property="availability" href="http://schema.org/OnlineOnly" />
  </li>
</ul>

Note that only the last 856 has the </a><link></li> section.

There are other pages with similar issues. This kind of thing can potentially cause issues with CSS application. I'll try to put a branch together to address as many as I can find.

Revision history for this message
Jason Boyer (jboyer) wrote :

I've got a few things taken care of here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1901710_html_nest_tags / working/user/jboyer/lp1901710_html_nest_tags

but the advanced search page needs some real help.

A couple ids were changed to classes because they're now used in multiple places also.

Changed in evergreen:
importance: Undecided → Medium
Garry Collum (gcollum)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Garry Collum (gcollum) wrote :

Jason's branch fixes the nesting issue with the 856 links and cleans up some other issues. A signed off branch for this portion of the work is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1901710_html_nest_tags-signoff

tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
tags: added: pullrequest
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_6. Thanks, Jason and Garry!

Changed in evergreen:
milestone: 3.6.4 → 3.7.1
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.