Cleanup Perl warnings in 'make check' and logs
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
3.6 |
Fix Released
|
Low
|
Unassigned |
Bug Description
Eg master as of 2020-09-15
Over time I've collected examples of log noise from perl warnings and after running make check manually to check the perl modules there are several more. I'm going to try to put together a branch that calms those down (and shrink some logs!)
Sample warnings from make check:
Possible precedence issue with control flow operator at ...lib/
Odd number of elements in anonymous hash at ...lib/
"my" variable $results masks earlier declaration in same scope at ...lib/
CGI::param called in list context from ...lib/
And various logs hither and yon:
(I think I've seen the hold targeter send some of these, not sure which version)
CALL: open-ils.cstore open-ils.
"order_by" object in a query is not a JSON_HASH or JSON_ARRAY;no ORDER BY generated
(caused by things like ...search_
open-ils.
open-ils.
"my" variable $circ_ids masks earlier declaration in same scope at ...OpenILS/
description: | updated |
Changed in evergreen: | |
milestone: | none → 3.6.1 |
tags: | added: cleanup |
Changed in evergreen: | |
milestone: | 3.6.1 → 3.6.2 |
Changed in evergreen: | |
milestone: | 3.6.2 → 3.6.3 |
Changed in evergreen: | |
assignee: | nobody → Jane Sandberg (sandbej) |
Changed in evergreen: | |
milestone: | 3.6.3 → 3.6.4 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Here's a branch that addresses all of the make check issues (though the logger is still annoyed that there's no config - perhaps it could somehow be set to warn...) and a small selection of things recently found in osrfwarn.log: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ jboyer/ lp1895660_ bring_the_ noise_wait_ dont / working/ user/jboyer/ lp1895660_ bring_the_ noise_wait_ dont
It builds ok and nothing is obviously broken but I'd invite as much poking as folks can spare, especially around EGCatLoader/ Search. pm because it has the largest number of changes. I want to avoid the warnings *and* the situation(s) being warned about...
I hesitate to open this door too widely but if you see some useless noise in your logs (actual noise; perl uninitialized variable stuff, not "This database is broken!") and can tell me how to trigger it in this bug I'll see what I can do about making it go away.