Bootstrap OPAC: follow up needed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned |
Bug Description
The experimental bootstrap OPAC is pretty sweet! Here are some things I noticed that need to be fixed about it, though:
1) The login_modal.tt2 file contains incorrect aria syntax. A div has aria-labelledby
2) In the advanced search, the filters don't open for me when I click them; I just get an error message in my console.
3) In the advanced search, the "Search" button isn't visible above the fold on several screens. Since search is the primary purpose of this page, it would be helpful to have a search button above the fold (maybe just before the filters) as well as at the bottom.
4) For the record actions (place hold, permalink, etc.), only the text within the buttons is clickable. The whole button should be clickable, so as not to require super-accurate mouse aim.
5) Also in the record actions, the Print/Email button performs different functions depending on where in the button you happen to click. Since this button performs two separate functions, it should be two separate buttons.
6) Basket dropdown: You can't use keyboard nav on the entries in this dropdown, because they have a tabindex of -1.
7) Basket dropdown, when embedded in the Angular staff catalog "Patron View" tab: every other link and button is turned off in this view, but the basket dropdown still is open-able; the entries in the dropdown don't do anything, however.
8) In search results: Show More Details used to show all sorts of bibliographic details. Now, it only shows a bib call number and some holdings-level details. It would be good to have some of those details back.
9) Tooltips (such as the guidance for login credentials or hold activation date) can't be opened using keyboard navigation.
10) In the basket view: the basket action buttons aren't working correctly here.
Changed in evergreen: | |
assignee: | nobody → Christopher Burton (cburton) |
tags: | added: pullrequest |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Oh, and one more: the language picker shouldn't need a separate "Save" button. Most language pickers I've seen just apply the new language when the user selects it.