Angular org-select persist key support; Staff catalog holds grid sticky org selector

Bug #1889113 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Evergreen 3.5 / Wishlist

The org selector in the staff catalog holds grid should be sticky based on server setting. (Other selectors as well, but we have to start somewhere).

Included in this change will be adding support for persist keys in the Angular org selector, similar to the AngularJS org selector.

Code en route which does the following:

* Adds support for reading/writing values to a server setting based on the presence of a persistKey in the <eg-org-select /> component.

* Adds support for a post-setting-lookup fallbackOrg[Id] which, if set, is applied after a setting lookup returned no values.

* Addition of a new @Output whose sole job is to report when the org select has finished all of it's load-time data fetching and a value has been applied (when possible)

* Improved code documentation explaining the order of operations and more clearly describing cases where an onChange may or may not fire.

* A new workstation setting to use as the persist key for the catalog holds org selector.

* Teaches the holds grid to wait until the org select has fully loaded to avoid duplicate / unnecessary data fetches.

Revision history for this message
Bill Erickson (berick) wrote :

Branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1889113-org-select-persist

To test:

[1] Navigate to the holds tab for a record in the experimental staff catalog.
[2] Change the pickup lib selector value.
[3] Reload the page and confirm the value selected matches the last value applied.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
status: In Progress → New
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Targeting this as a bug fix, since it's less a new feature, and more maintaining consistency with the AngularJS interface.

Changed in evergreen:
status: New → Confirmed
importance: Wishlist → Medium
milestone: 3.6-beta → 3.5.2
assignee: nobody → Jane Sandberg (sandbej)
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Bill and Terran. It's nice to have this feature for org-select. Pushed to master and rel_3_5.

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.