Cancel Hold on Holdshelf Leaves Item in Limbo if Uncancelled

[Ryan Eby]

The current cancel hold function checks if the item is on the holdshelf but doesn't do anything but log that it is:

https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm;hb=c1c87fd63733044b95bbf5de70898448059b9df8#l836

This is fine in most cases since the item will show up on the clear holds list.

If the item is immediately uncancelled because it was a mistake then the item remains on the holdshelf status while the hold record is cleared out of any association with the item. So you get a fresh looking hold request while the item is still on the holdshelf for that patron.

https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm;hb=c1c87fd63733044b95bbf5de70898448059b9df8#l748

There probably isn't a good status that cancel can put it in but it might be useful if the uncancel could handle keeping the association with the copy if the copy is still on holdshelf and there are no other captured/shelf holds for that copy id.

[Josh Stompro (u-launchpad-stompro-org)]

Hello Ryan, we have run into this also, and it always causes grief since it takes a while to figure out what happened.

I wonder if something similar can also be caused by retargeting(find another target) a hold when the copy is on the holdshelf? We were trying to find an easy way to suspend holds when customers told us they were not currently comfortable coming in to pickup materials. And going the (find another target) then suspending the hold route to get there with the least amount of steps.

Josh