Evergreen

AngularJS hotkeys can fail to be initialized

Bug #1886713 reported by Galen Charlton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Status tracked in Main
3.4
Fix Released
Undecided
Unassigned
Evergreen 3.4.4
Main
Fix Released
Medium
Unassigned
Evergreen 3.5.1

Bug Description

Some menu items in the AngularJS navbar are displayed only if certain library settings are set. However, there is a race condition where even if a menu item is displayed, it may not have entered the DOM soon enough for the navbar services to find its eg-accesskey attribute.

In particular, the F8 hotkey to retrieve the previous patron is prone to this bug.

Evergreen 3.3+

Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available in the branch

working/user/gmcharlt/lp1886713_fix_hotkeys_race /
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1886713_fix_hotkeys_race

tags: added: circulation pullrequest
Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Worked for me. Signoff pushed to user/rogan/lp1886713_hotkeys_fix

tags: added: signedoff
Revision history for this message
Mike Rylander (mrylander) wrote :

Merged for keyboard joy. Thanks, Galen and Rogan!

Changed in evergreen:
assignee: nobody → Mike Rylander (mrylander)
assignee: Mike Rylander (mrylander) → nobody
status: New → Fix Committed
Mike Rylander (mrylander)
Changed in evergreen:
milestone: none → 3.5.1
Evergreen Bug Maintenance (bugmaster)
no longer affects: evergreen/3.6
no longer affects: evergreen/3.5
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.