Angular access keys stored in incorrect order / precedence

[Bill Erickson]

Evergreen 3.5

The egAccessKey directive for mapping keyboard shortcuts in the Angular client stores the key assignments in the wrong order. This can lead to giving conflicting shortcuts the wrong precedence and displaying the shortcuts in a confusing order in the control-h help dialog.

Tiny patch en route.

[Bill Erickson (berick)]

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1883126-ang-accesskey-order

To test:

1. Navigate to an Angular page in the staff client (e.g. Administration -> Server Administration)
2. Use control-h on the keyboard.
3. Note two 'Patron Search' shortcuts that are separated by other shortcuts, even though they were assigned one right after the other.
4. Apply the patch, and now the two will be displayed one atop the other and generally in reverse assignment order.

[Terran McCanna (tmccanna)]

Confirmed that it does what it says it does - my signoff is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1883126-ang-accesskey-order-signoff

[Bill Erickson (berick)]

Thanks, Terran. Merged to 3.4 and above.