Angular access keys stored in incorrect order / precedence
Bug #1883126 reported by
Bill Erickson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
3.4 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Evergreen 3.5
The egAccessKey directive for mapping keyboard shortcuts in the Angular client stores the key assignments in the wrong order. This can lead to giving conflicting shortcuts the wrong precedence and displaying the shortcuts in a confusing order in the control-h help dialog.
Tiny patch en route.
Changed in evergreen: | |
assignee: | Bill Erickson (berick) → nobody |
Changed in evergreen: | |
milestone: | 3.5.0 → 3.5.1 |
Changed in evergreen: | |
milestone: | 3.5.1 → 3.6-beta |
milestone: | 3.6-beta → 3.5.2 |
Changed in evergreen: | |
assignee: | nobody → Bill Erickson (berick) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix pushed:
https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ berick/ lp1883126- ang-accesskey- order
To test:
1. Navigate to an Angular page in the staff client (e.g. Administration -> Server Administration)
2. Use control-h on the keyboard.
3. Note two 'Patron Search' shortcuts that are separated by other shortcuts, even though they were assigned one right after the other.
4. Apply the patch, and now the two will be displayed one atop the other and generally in reverse assignment order.