Staff catalog TCN search include deleted

Bug #1881650 reported by Bill Erickson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen 3.5 / Wishlist

The Angular staff catalog has a TCN search under the Identifier search tab. Unlike the Cataloging => Retrieve Record by TCN Value menu action, however, it does not return results for deleted bib records. Since the staff catalog is staff-only, it should include deleted records in TCN searches for consistency.

On a related note, the Angular bib summary component needs a (Deleted) indicator consistent with AngJS.

Revision history for this message
Bill Erickson (berick) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.next
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
Revision history for this message
Mary Llewellyn (mllewell) wrote :

Catalog/Retrieve Bib Record by TCN retrieves a deleted record, labeled as (Deleted) in red font and the text "This record has been deleted from the database. We recommend that you remove this title from any lists it may have been added to. " in a red box.

Numeric Seaech/TCN (identifier|tcn:252) does not retrieve the deleted record. This was using the Traditional staff catalog search.

Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Revision history for this message
Bill Erickson (berick) wrote :

Hi Mary, to clarify, the changes introduced in this branch affect the new Angular staff catalog and not the traditional catalog. Are you saying that you navigated to Cataloging => Search The Catalog (Traditional) to test? If so, that would not cover these changes.

Revision history for this message
Terran McCanna (tmccanna) wrote :

The angular catalog is broken on my test server at the moment - working on it...

Revision history for this message
Mary Llewellyn (mllewell) wrote :

Hi Bill, my bad. OK, I'm testing the angular numeric search on TCN and was able to find a deleted bib (one I imported then deleted.) See attached.

Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
Revision history for this message
Mary Llewellyn (mllewell) wrote :

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>

tags: added: signedoff
Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

I'm splitting off the patch that makes the Angular catalog indicate if a record is deleted to a new bug, bug 1896629, as that's more of a regression whose fix should make it into 3.6-beta2. The wishlist item about making the TCN search include deleted records will remain a wishlist item on this bug for a future release.

Changed in evergreen:
status: New → Confirmed
summary: - Staff catalog TCN search include deleted / add deleted indicator
+ Staff catalog TCN search include deleted
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: 3.next → 3.7-beta
Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed the enhancement to master for inclusion in 3.7. Thanks, Bill and Mary!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.