Carousels need option to display/scope separate from initial search location

Bug #1879790 reported by Jennifer Bruch
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

PaILS is using this feature on version 3.3

Currently, visible carousels are selected based on the physical_loc apache variable. Before carousels existed, this was also used to set the initial search location. Because there are some locations that would like to separate carousel selection from physical location, it would be useful to create a new, separate apache parameter for carousel scoping and fall back to physical_loc if that is not set.

tags: added: carousel
Revision history for this message
Mike Rylander (mrylander) wrote :

There's a branch available at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1879790-separate-carousel-scope which provides a separate carousel_loc apache environment peer to physical_loc. Still needs release notes...

tags: added: pullrequest
no longer affects: evergreen/master
Changed in evergreen:
milestone: none → 3.next
no longer affects: evergreen/3.4
no longer affects: evergreen/3.5
tags: added: needsreleasenote
Changed in evergreen:
importance: Undecided → Wishlist
no longer affects: evergreen/3.6
Revision history for this message
Terran McCanna (tmccanna) wrote :

This still needs release notes with an example of creating the new setting.

Revision history for this message
Terran McCanna (tmccanna) wrote :

I tested this by adding this line to eg_vhost.conf and restarting apache:

SetEnv carousel_loc 6

It does indeed force the carousel I created for location 6 (BR3) to always be displayed, but it also prevents carousels that were set for any other location from being displayed. Is that the desired behavior?

(In PINES, we currently allow patrons to view our new item carousels for any location by switching the physical_loc in the URL. We wouldn't use a setting like this in our organization because it prevents that URL switch from working.)

Revision history for this message
Jennifer Bruch (jbruchpails) wrote :

This was created to address an issue that PaILS SPARK ran into because we have libraries with their own OPAC who scope it on a system level but want to display a carousel with content only from their own individual library. Usually new titles that cannot be resource shared.

It is hard to test this fix as a result because the situation is so unique.

But here are two live OPAC as examples:

Scoped to system/consortium (can't have carousels)
https://catasauqua.sparkpa.org/eg/opac/home

Scoped to library in that system (can have carousels)
https://parkland.sparkpa.org/eg/opac/home

Revision history for this message
Mike Rylander (mrylander) wrote :

Hi Terran,

Yes, that's the intended behavior.

A word of warning about the physical_loc CGI parameter -- that ends up getting put into a cookie and has side effects that you may not want, such as truncating the org dropdown for a "global" vhost in that specific browser until the cookie is manually removed if org hiding is in use by the physical_loc org.

I've pushed a rebased and updated branch that allows the user to override the carousel location with a cgi parameter to support the PINES use case without the risk of locking your browser into an unintended physical_loc:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1879790-separate-carousel-scope-with-cgi

Thanks!

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: signedoff
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Pushed to master. Thanks, Terran, Jennifer, and Mike!

Changed in evergreen:
status: Confirmed → Fix Committed
milestone: 3.next → 3.7-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.