Angular staff catalog "Add Callnumbers" ignores org-only rows / Edit holdings support

[Bill Erickson]

Evergreen 3.4

In the Angular catalog Holdings grid, when the user selects a row in the grid which only describes an org unit (i.e not a specific call number or item), that org unit is ignored when selecting either of the "Add Call Numbers" actions. This results in attempting to create a single call number with owning lib of "here". Instead, the selected org(s) should affect both the number of call numbers to create and the owning libs for each.

[Bill Erickson (berick)]

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1878079-staffcat-holdings-from-org-rows

===

From the commit:

When adding new call numbers from the Angular staff catalog Holdings View grid, take all selected grid rows into consideration when determining how many call numbers to add and what their owning libs should be.

To test:
* Navigate to the Holdings View tab of a record detail page in the Angular staff catalog.
* Select multiple rows in the grid which are org unit-only rows (i.e. the row does not refer to a specific call number or item).
* From the action menu / right client menu, select "Add Call Numbers"
* Confirm that a call number entry for each selected org unit is present in the spawned holdings editor.

[Bill Erickson (berick)]

Temporarily removing pullreq... need to add a can_have_vols() check to the modified code.

[Bill Erickson (berick)]

While testing the fix I found the Angular Catalog did not correctly implement the various holdings "Edit" options (Edit Items, Edit Call Numbers, Edit Call Numbers and Items). I've pushed an additional set of fixes to address those issues as well.

The net result is all of the Add / Edit ... Call Numbers / Items / Call Numbers and Items actions from the holdings grid now match the behavior of the AngJS holdings grid.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1878079-staffcat-holdings-from-org-rows

[Jane Sandberg (sandbergja)]

Thanks for the branch, Bill. When testing, though, it seems like the "Add Holdings" button is no longer working properly. When I select a library in the holdings grid, and click Add Holdings, I get a partial holdings editor in which I can't add any holdings at all. :-(

[Bill Erickson (berick)]

Thanks, Jane. The code posted so far only addresses the behavior of the grid. I didn't even think about the Add Holdings button. I'll see if I can get that fixed too.

[Bill Erickson (berick)]

Rebased branch with fixes for the 'Add Holdings' button pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1878079-staffcat-holdings-from-org-rows-2

[Jane Sandberg (sandbergja)]

Thanks, Bill! Works well for me. Pushed to master and rel_3_5.

The 3.4 backport had some merge conflicts. I've tried to resolve those (user/sandbergja/LP1878079_rel_3_4_backport). It's compiling, but I haven't had a chance to make sure that the functionality is the same. I'll finish testing that out today or tomorrow.

[Jane Sandberg (sandbergja)]

Backported to rel_3_4