Angular Staff Catalog Format Drop Down List Not Using Search Labels or Observing OPAC Visible Value

Bug #1872867 reported by Jennifer Pringle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

Evergreen 3.5 Beta

The format drop down list in the angular catalogue appears to come from the SVF Attributes for Search Formats (Administration -> Server Administration - > MARC Coded Value Maps).

The drop down list seems to pull all Search Formats into the list regardless of whether or not they have been marked as OPAC Invisible (which may be desired behaviour in the staff catalogue). It also uses the names for the format filters from the "Value" field rather than the "Search Label" field.

On our 3.5beta test server with our data, in the old catalogue the format filter list displays using the Search Label and only displays those that are set to OPAC Visible = True. In the angular catalogue the whole list appears and uses the "Value" field for the names.

I looked at the 3.4.1 community server and the Item Form list in the old catalogue is significantly different from the Search Formats list in the MARC Coded Value Maps so I think I'm missing a piece of how this works. The format drop down list in the angular catalogue though is the full list from the MARC Coded Value Maps, same as I'm seeing in 3.5beta

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

Fix for display labels pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1872867-staffcat-format-labels

All of the coded value map filters will use search_label when a value is present, otherwise it falls back to using the value field.

Branch does not include opac_visibility changes. Feedback needed on whether it should.

Changed in evergreen:
milestone: none → 3.5.1
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

It may be different for other consortia and libraries but for us the Search Format set to OPAC Visible = No are the ones we don't currently use at all. There may be some that we'd want to use in the future so I'd be hesitant to simply delete them to stop them from display in the staff catalogue.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Idea - what if the ones marked OPAC Visible = No had some sort of indicator in the staff client? Perhaps appending them in the list with " (Hidden)" or something like that?

tags: added: needsdiscussion
Changed in evergreen:
milestone: 3.5.1 → 3.4.5
milestone: 3.4.5 → 3.5.2
Revision history for this message
Elaine Hardy (ehardy) wrote :

I think that it would be a good thing to have a search filter marked OPAC invisible display in the staff client with a label marking it as invisible.

While I can see that it might confuse some staff, it would also serve as a reminder of the filter's existence. In a consortium, we don't always realize a member library has purchased a new format until it is in the collection (or we are asked how to catalog it). So if the filter is visible to staff, it might cue them to ask for the filter to be activated.

Revision history for this message
Bill Erickson (berick) wrote :

+1 to (Hidden) option.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
tags: removed: needsdiscussion
Revision history for this message
Elaine Hardy (ehardy) wrote :

I have tested this code and consent to signing off on it with my name, Elaine Hardy and my email address, <email address hidden>

Tested on https://acorn.evergreencatalog.com/eg/staff and https://acorn.evergreencatalog.com/eg/opac

Two search filters were set to invisible by others -- Electronic and Microfirm. Both displayed in the filter list in the staff column as Electronic (Hidden) and Microform (Hidden).

In the public facing OPAC, the filters are not in the list. I was able to search and retrieve a record with the hidden format. Appears to work as desired

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Elaine.

The commit did not merge cleanly with 3.4, so I have opted to merge to 3.5 and up for now.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
no longer affects: evergreen/3.4
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

To discuss hiding opac invisible entries from the angular staff catalog I've started bug 2038476 as a follow-up.
Josh

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.