Experimental catalog: baskets persist after logging out and logging in as a different user

[Jane Sandberg]

Steps to recreate:
1) Log into the Evergreen Staff Client using one set of credentials.
2) Go to the experimental catalog
3) Do a search, and add some items to your basket (by clicking the checkboxes next to the relevant entries in your search results).
4) Note the number of records in your basket.
5) Log out, and log in as a different user with the same workstation.
6) Go to the experimental catalog
7) Note that you still have those records in your basket

I'm pretty sure that this is not the behavior we want. But maybe it could be helpful for some workflows that I can't foresee? Adding the needsdiscussion tag just in case.

[Bill Erickson (berick)]

Confirmed and agreed the list should clear on logout. (That was the intention of the code, but it missed a piece). If staff need a list to persist, it can be saved to a bucket.

[Bill Erickson (berick)]

Here's a wee fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1867834-staffcat-clear-basket

[Jane Sandberg (sandbergja)]

Works well for me. Thanks, Bill. Signoff at user/sandbergja/lp1867834-staffcat-clear-basket-signoff

[Galen Charlton (gmc)]

I don't think the signoff branch made it to the working repository, so I went ahead and manually added Jane's signoff to the commit. Pushed to master, rel_3_5, and rel_3_4. Thanks, Bill and Jane!

[Galen Charlton (gmc)]

Ah, it had; there was just a typo in the branch name.