Multi day closing could be clearer

[Jane Sandberg]

For multi day library closings, the "End" day is not particularly clear. Some of our staff were wondering if this field refers to the last day the library is closed (which is correct), or the first day the library is open. In other words, does the closure end at the start of the selected day, or the end of the selected day.

I agree that this could be clarified. Branch forthcoming.

[Jane Sandberg (sandbergja)]

Here's a branch: user/sandbergja/lp1867524_add_help_popover_for_closing_dates_editor

Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1867524_add_help_popover_for_closing_dates_editor

Here are the testing notes from the commit message:

1) Go to Administration > Local Administration > Closed Dates Editor.
2) Click Add Closing.
3) Under closing type, choose Multiple Day.
4) Note that the End field has no guidance for the user.
5) Apply this commit.
6) Repeat steps 1-3.
7) Notice that the End field has some clarifying guidance for the user.

[Mike Risher (mrisher)]

I tested it out and think it's more clear now. Thanks for including thorough testing notes!

I have tested this code and consent to signing off on it with my name, Mike Risher and my email address, <email address hidden>

[Galen Charlton (gmc)]

Pushed all the way to rel_3_4. Thanks, Jane and Mike!