A few inconsistent strings in the Angular i18n login screens

Bug #1865951 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

In Open-ILS/src/eg2/src/app/staff/login.component.html, the strings "Sign In" and "Sign in" are both used (one with a lower-case i, the other with an upper case one). Let's choose one and stick with it.

Similarly, Open-ILS/src/eg2/src/app/staff/login.component.html uses "Username" and "Password" for the placeholder text, but Open-ILS/src/eg2/src/app/staff/share/op-change/op-change.component.html uses "Username..." and "Password...". Let's get rid of the "..." so that translators have 2 fewer strings to translate.

Revision history for this message
Shula Link (slink-g) wrote :

I'll grab this and knock it out today.

I'm thinking "Sign In" looks a bit better as a standalone string, aesthetically.

Changed in evergreen:
assignee: nobody → Sam Link (slink-g)
Revision history for this message
Shula Link (slink-g) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Sam Link (slink-g) → nobody
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Sam! When I go to that link, though, I don't see your commit. Could you please try pushing your commit again?

Revision history for this message
Shula Link (slink-g) wrote :

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/slink/1865951_inconsistent_strings_in_the_angular_login_screens

Does that work? They just upgraded our work computers, and this is my first push to Evergreen since the changeover so I'm hoping everything worked normally.

Revision history for this message
Shula Link (slink-g) wrote :

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=9e671268b3db6c4b21f939e974a8823da90ee6f8

I'd forgotten the important step of actually doing the commit locally.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Sam! I'll take a look.

Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
milestone: none → 3.5-alpha
milestone: 3.5-alpha → 3.4.3
Revision history for this message
Jane Sandberg (sandbergja) wrote :

I've confirmed that this works well. When I run `npm run export-strings`, the resulting messages.xmb file no longer contains those duplicate strings. Pushed to master, rel_3_5, and rel_3_4.

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.