OPAC Hold edits no longer save

[Terran McCanna]

In Evergreen 3.4.2:

If a patron suspends a hold and then goes into their holds list to edit it through the OPAC, they can select a hold activation date, change status between suspended/activated, change notification preferences, etc. but none of the changes actually save. (The Actions drop down still works to suspend/activate, but not the Edit options.)

To recreate:

1. Log into the OPAC.
2. Place a hold.
3. Go to My Account > Holds > Items On Hold
4. Click the Edit link next to the hold you placed and edit the pickup location, active/suspended status, notification method, etc. and Submit.
5. Return to My Account > Holds > Items On Hold to see that none of the changes were saved.

[Josh Stompro (u-launchpad-stompro-org)]

I think this was also noted by Dawn Dale in comment 8 of bug #1783793 for evergreen 3.4.1.

Josh

[Josh Stompro (u-launchpad-stompro-org)]

I tested our 3.3.4 system and the opac hold edit button features seem to work fine in that version.
Josh

[Jennifer Pringle (jpringle-u)]

Tested this in 3.5 beta and I can confirm that changes made in the Edit screen under Items on Hold in the OPAC don't save.

I've tried suspending with an activation date, adding a Cancel unless filled by date, and changing the Phone Notification number.

Clicking Submit takes me back to the Items on Hold screen without displaying an error but my change is not saved.

[Jeff Davis (jdavis-sitka)]

A blank "SMS Notification" field is being treated as an empty string ("") rather than a null value, which causes the hold update to fail. Working branch user/jeffdavis/lp1865533-edit-hold-save-changes has a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1865533-edit-hold-save-changes

[Jennifer Pringle (jpringle-u)]

This fix works for me on our 3.5beta test server. I'm leaving it to someone else to test and signoff though (since I'm at the same org at Jeff).

[Terran McCanna (tmccanna)]

Works for me, too! My signoff here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/l01865533-edit-hold-save-changes-signoff

[Chris Sharp (chrissharp123)]

Pushed to master and 3.5 - thanks Jeff, Jennifer, and Terran!

[Galen Charlton (gmc)]

Noting for anybody who was confused, like me, that this wasn't a bug in stock 3.4.x, but was an problem in 3.5-beta; the regression was due to the original patches for bug 1570072.