Upgrade to Angular 10

[Jane Sandberg]

Angular 9 is out. It's an exciting release, since it has the new Ivy renderer, which promises some performance improvements.

It also looks like we might be able to deprecate the eg-string component in favor of using $localize directly in the typescript code: https://blog.ninja-squad.com/2019/12/10/angular-localize/

[Jane Sandberg (sandbergja)]

A note that ng-bootstrap has an Angular 9-compatible release, but it deprecates ngb-tabset in favor of a new ngb-nav component. That will cause us some work during this upgrade...

[Bill Erickson (berick)]

Work in progress here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1864371-angular-v9

So far, so good. Note ngb-tabset is still available in ng-bootstrap 6.1.0 so it's not strictly required we replace all of the tabs. However, I have successfully migrated one set of tabs to see what the process looks like. It's not too bad. Here's the MARC editor tabs migration:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=e68712ab3e0bee82ae8c4b13d75aa0062025c871

[Bill Erickson (berick)]

I propose we go ahead and make the jump to Angular 10!

https://blog.angular.io/version-10-of-angular-now-available-78960babd41

The release is by the Angular team's admission "smaller than typical". I was able to build eg2 using Angular 10 without any changes specific to Angular 10 apart from dependency updates.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1864371-angular-v10

Ng-bootstrap does not officially support Angular 10 yet, but they tend to catch up pretty quickly. Plus, in my tests so far, things are working fine with ng-bootstrap 6.1.0. And we have a few months before this code would be released.

[Galen Charlton (gmc)]

And ng-bootstrap 7 now officially supports Angular 10.

[Galen Charlton (gmc)]

Noting that the consensus of today's dev meeting is to make the jump all the way to 10.

[Jane Sandberg (sandbergja)]

My testing went well. It will be nice to have those performance improvements from the newer AOT compiler! Signoff at user/sandbergja/lp1864371-angular-v10

[Galen Charlton (gmc)]

I've tested this and pushed a branch with a couple follow-ups:

- fix a lint complaint
- go ahead and update ng-bootstrap to 7.0.0

The ng-bootstrap change doesn't seem to have any immediate side-effects.

Branch is user/gmcharlt/lp1864371_signoff

[Galen Charlton (gmc)]

(Noting that bootstrap-css-only hasn't yet released a 4.5.1 yet, but that doesn't appear to be a problem at the moment.)

[Bill Erickson (berick)]

Thanks, Galen. I'm going to give this a once-over with your updates.

[Bill Erickson (berick)]

Sign off to Galen's 2 tip commits pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1864371-angular-v10-2

I did a fresh install from the working branch, poked around, ran tests and lint, and did not have any issues.

[Bill Erickson (berick)]

And.... merged to master. Thanks All!