Record Buckets - Batch Edit redirect - Regex replace that fails for us
Bug #1862694 reported by
Josh Stompro
This bug report is a duplicate of:
Bug #1862834: regex based url building that can match hostnames.
Edit
Remove
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
New
|
Undecided
|
Unassigned |
Bug Description
EG 3.3.4
Our hostname contains a prefix of eg, so the code for batch editing records from a bucket fails for us, since it does a regex replace using /\/eg.*/ to create the new URL. So we cannot load the batch edit interface.
"https:/
gets turned into
"https:/
$scope.
Josh
Changed in evergreen: | |
milestone: | none → 3.6.1 |
tags: | added: cleanup |
Changed in evergreen: | |
milestone: | 3.6.1 → 3.6.2 |
Changed in evergreen: | |
milestone: | 3.6.2 → 3.6.3 |
Changed in evergreen: | |
milestone: | 3.6.3 → 3.6.4 |
Changed in evergreen: | |
milestone: | 3.6.4 → 3.7.2 |
Changed in evergreen: | |
milestone: | 3.7.2 → 3.7.3 |
Changed in evergreen: | |
milestone: | 3.7.3 → none |
no longer affects: | evergreen/3.6 |
To post a comment you must log in.
I found one other instance that could cause problems, if anyone has a hostname starting with staff.
https:/ /git.evergreen- ils.org/ ?p=Evergreen. git;a=blob; f=Open- ILS/web/ js/ui/default/ staff/cat/ item/app. js;hb=HEAD# l1145
var url = $location. absUrl( ).replace( /\/staff. */, '/actor/ user/event_ log');
That would match /staff. taco.org/ eg/staff/ opac
https:/
I think it both cases the regex just needs to include the trailing forward slash so it cannot match the beginning of the hostname.
Unless "$scope. batchedit_ url = $location. absUrl( ).replace( /\/eg.* /, '/opac/ extras/ merge_template' );" is supposed to match /eg2/ or /eg/ ?
Josh