pingest.pl should use the rdeleted parameter when ingesting record attributes

Bug #1862652 reported by Jason Stephenson on 2020-02-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.3
Undecided
Unassigned
3.4
Medium
Unassigned
3.5
Medium
Unassigned

Bug Description

Evergreen version 3.4.1 (affects version 3.3.0+)
PostgreSQL version 9.6.16
OpenSRF Version 3.2.0 (N/A)

The pingest.pl program takes an option to specify which record attributes to reingest when run without the --skip-attrs option specified. However, it does not specify a value for the rdeleted parameter of the metabib.reingest_record_attributes function. The rdeleted parameter defaults to a TRUE value, which bypasses the pattr_list parameter. Thus, the value(s) of the --attr parameter(s) are ignored and all record attributes are reingested by pingest.pl.

This can be fixed by using the deleted column value of the record being ingested.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Here's a branch that uses the deleted field of the biblio.record_entry being ingested when metabib.reingest_record_attributes is run in the pingest.pl support script:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1862652-pingest-reingest-record-attrs-rdeleted

tags: added: cataloging pullrequest search
Changed in evergreen:
milestone: none → 3.5-alpha
description: updated
Changed in evergreen:
milestone: 3.5-beta → 3.5.0
Changed in evergreen:
milestone: 3.5.0 → 3.5.1
Revision history for this message
Jane Sandberg (sandbej) wrote :

Thanks, Jason. To check my understanding: the deleted field of the biblio.record_entry being ingested will always be false, right? Since pingest.pl doesn't (yet?) have a way to revive deleted records into undeleted ones?

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Jane, not in all cases. You can send a list of record ids into pingest.pl. That list can include deleted records.

Basically, what I found was that all of the fields were being reingested on non-deleted records, when I asked for only certain fields to be reingested. This patch corrects that for non-deleted records and still ingests all fields when a deleted record is being reingested.

Hope that makes sense.

Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Changed in evergreen:
milestone: 3.5.2 → 3.6-beta
Changed in evergreen:
milestone: 3.6-beta → 3.6-beta2
importance: Undecided → Medium
Galen Charlton (gmc) on 2020-09-30
Changed in evergreen:
milestone: 3.6-beta2 → 3.6-rc
Galen Charlton (gmc) on 2020-10-07
Changed in evergreen:
milestone: 3.6-rc → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Revision history for this message
Jason Stephenson (jstephenson) wrote :

BTW, this patch makes a huge performance difference when doing an attribure only ingest, particularly if a list of attributes is specified.

I'm presently ingesting only the mr_hold_format attribute of our non-deleted records, and it is going much more quickly after applying this patch.

Changed in evergreen:
milestone: 3.6.3 → 3.6.4
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers