WebClient - Angularjs Hotkeys Shortcut List - Doesn't scroll for longer lists

Bug #1862230 reported by Josh Stompro on 2020-02-06
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

EG 3.3 - I'm working on adding other keyboard shortcuts to the AngularJS client and noticed that the list of keyboard shortcuts (shown by pressing ?) doesn't handle longer lists of shortcuts. When I added 8 more shortcuts the list just gets cut off when it flows off the screen, and there is now way to see the rest.

I don't know if the Angular shortcuts (ctrl+h in the Angular catalog) has the same problem.

Using the angular-hotkeys project, it looks like it is possible to apply a custom Cheatsheet template, which should allow for using more columns and scrolling.

https://github.com/chieffancypants/angular-hotkeys/

Josh

This has come up a few times in the Angular-hotkeys project github issues.

There are a few options such as enable scrolling, or multi columns.

https://github.com/chieffancypants/angular-hotkeys/issues/257
https://github.com/chieffancypants/angular-hotkeys/issues/248

Here is a fork of angular-hotkeys that has some fixes for examples.
https://github.com/chieffancypants/angular-hotkeys/compare/master...ylerjen:master

Josh

Adding both 2 columns and scrolling seems to work just fine.... but, how does one modify a module that is pulled in at build time.

Or maybe overriding is the way to go, don't try to modify the source?
/openils/var/web/js/ui/default/staff/build/css/hotkeys.min.css

Josh

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.