Can delete copy that is not in ideal status without warning (Angular Edition)

Bug #1860460 reported by Bill Erickson on 2020-01-21
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

Spun off of bug #1735566

Need to properly handle item deletion and permission overrides in the new Angular holdings delete dialog.

Bill Erickson (berick) on 2020-01-21
Changed in evergreen:
milestone: none → 3.4.2
Bill Erickson (berick) wrote :

Fixes pushed:;a=shortlog;h=refs/heads/user/berick/lp1860460-copy-delete-special-status

Note this also includes general purpose (staff) permission override handling for permission failure events trapped by the network code.

Bill Erickson (berick) wrote :

For testing, follow the steps listed here, replacing copy bucket interface with the experimental catalog Holdings View interface.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Jennifer Weston (jweston) wrote :

Tested. Behaves as expected. The error message is clear and helpful -- "Reason(s) include: The copy in question is not in an ideal status for deleting"

I have tested this code and consent to signing off on it with my name, Jennifer Weston, and my email address, <email address hidden>.

tags: added: signedoff
Jane Sandberg (sandbej) wrote :

Thanks, Bill and Jennifer! Pushed to master and rel_3_4.

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers