Booking - add field for note when making reservation

Bug #1859728 reported by Terran McCanna on 2020-01-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

When making a reservation in the booking module, it would be helpful to be able to add a note to the reservation (particularly for booking things like meeting rooms):

Use case: A meeting room is being reserved, but needs the tables set up in a particular configuration. Having a note field would allow manual entry of room requirements.

Use case: A meeting room is reserved on a staff account for a library-sponsored event. Having a note field would allow the name / description of the event.

Use case: A meeting room is reserved for a member of the public who does not have a library card. The reservation could be made on a staff card, but having a note field would allow relevant contact information to be stored.

Jane Sandberg (sandbej) wrote :

Oh wow, good catch, Terran! This was an oversight on my part during the Booking Refresh.

There is a notes field available (in fact, you can add notes to existing reservations in the Manage Reservations screen). I just forgot to include it on the new reservation screen.

I should be able to share a branch for this before too long.

Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
status: New → Confirmed
Jane Sandberg (sandbej) wrote :

A branch is available here: user/sandbergja/lp1859728_add_notes_when_creating_reservation

It feels kinda weird to call this a new feature, since it was just a case of me forgetting to add a field to a form. However, if this seems like more of a feature than a bugfix, I am happy to throw in a quick release note to that branch as well. Thoughts?

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Terran McCanna (tmccanna) wrote :

We tried installing this to a 3.4.1 test server and the field showed up but the form wouldn't save. I'm not seeing any errors in the console. I wonder if it's relying on newer code than I have on there? Thought I'd check first before I do too much digging. (I'm logged in as global admin, so I don't think it is a permissions issue.)

Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Jane Sandberg (sandbej) on 2020-01-15
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Jane Sandberg (sandbej) wrote :

Thanks for trying this out, Terran! I wasn't able to recreate that issue. I tried installing an old version of Booking.pm, and that just caused the reservations to save without the notes field. I tried installing a version of fm_IDL.xml that didn't have a notes field for bresv (booking.reservation), but that caused a lot of dramatic errors in the UI and the console.

I'm curious -- do you have access to the logs on the test server? If so, do you see anything interesting in these two logs when you try to create a reservation with a note?

* /openils/var/log/open-ils.booking_stderr.log
* /openils/var/log/osrfsys.log (particularly anything about open-ils.booking.reservations.create)

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers