non-title holds can be hidden from View Holds tab when bib changes

[Rogan Hamby]

Take a volume hold and look at the View Holds tab for it's bib record. The hold appears. Now merge the record's assets to a new bib where the current volume is kept (copies not moved to another volume volume). Because the volume is kept the hold is not updated. Since the hold is not updated the reporter.hold_request_record_mapper is never triggered and the value in bib_id is never updated. This can be easily verified in the database. Since the context bib must match the bib_id entry the holds are now hidden.

There might be other ways this becomes a problem other than during record merges.

[Rogan Hamby (rogan-hamby)]

A little more data, the specific issue that the on UPDATE the trigger function skips re-assigning the record value if the target and hold_type have remained the same ... which of course does not mean that the parent bib hasn't changed. We could fix that my basically flattening out the trigger function to always run but that's a lot of overhead for every hold update versus a relatively uncommon merging of records. I'm more inclined to add logic to merging record assets to address this but that has the disadvantage of essentially duplicating logic in two places which is .... not good.

[Rogan Hamby (rogan-hamby)]

For seeing affected holds:

select ahr.id, 'V' as hold_type
from reporter.hold_request_record rhrr
join action.hold_request ahr on ahr.id = rhrr.id
join asset.call_number acn on acn.id = ahr.target
where ahr.fulfillment_time is null and ahr.cancel_time is null and (ahr.expire_time is null or ahr.expire_time > now()) and ahr.hold_type = 'V'
and acn.record != rhrr.bib_record
UNION ALL
select ahr.id, 'C' as hold_type
from reporter.hold_request_record rhrr
join action.hold_request ahr on ahr.id = rhrr.id
join asset.copy ac on ac.id = ahr.target
join asset.call_number acn on acn.id = ac.call_number
where ahr.fulfillment_time is null and ahr.cancel_time is null and (ahr.expire_time is null or ahr.expire_time > now()) and ahr.hold_type = 'C'
and acn.record != rhrr.bib_record
UNION ALL
select ahr.id, 'P' as hold_type
from reporter.hold_request_record rhrr
join action.hold_request ahr on ahr.id = rhrr.id
join biblio.monograph_part bmp on bmp.id = ahr.target
where ahr.fulfillment_time is null and ahr.cancel_time is null and (ahr.expire_time is null or ahr.expire_time > now()) and ahr.hold_type = 'P'
and bmp.record != rhrr.bib_record
;

[Elaine Hardy (ehardy)]

This is still occurring in 3.8.0.

 Merging records does not fully transfer non-title holds to the target record. The hold remains and will process correctly but is not visible in the current record view holds. It is visible in the patron record and on the merged and deleted record

Transferring volumes/items may also have the same issue.

[Britta Dorsey (bdorsey-isl)]

This is still an issue in 3.9.2.

A record with part-level holds was merged (as lead) with another record. The holds are no longer visible under View Holds, but are accessible via the patron accounts.

[[e-mail] (tji)]

This is occurring in 3.11.1.

Copy level holds were left at the old bib after transferring copy + volume to another bib.