Angular grid link selector and filter repairs
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Evergreen 3.4
While diagnosing an issues using grid filters and showLinkSelector, I stumbled on a number of issues in the grid, idl, and combobox code that required some tweaking.
* Grid showLinkSelectors no longer serves any purpose, since the format service (used by the grid) now renders link selector values whenever it can.
* The code which extracts the IDL information on grid fields suffers from an off-by-one issue when stamping the IDL class for a field. E.g. rendering an A/T event definition row, it stamps "hook" with the "ath" class, even though it's a column on an "atevdef" object. In this example, "hook.key" should be stamped as class "ath". In particular, this off-by-one breaks the aforementioned format service link selector rendering.
* IDL field extraction behaves differently for auto fields vs fields declared in the markup.
* Column 'name' should suffice for IDL field data extraction when no 'path' attribute is defined.
* The code that determines the field name of the selector on a linked class could be smarter by only using 'name' as a fallback if such a field exists on the class. It could also be better consolidated into the IDL service.
* Grid filter comboboxes don't respond well to clearing the combobox value (console errors).
* Comboboxes attempt to load async data using _CLICK_ as a search term when clicked and asyncSupportsEm
Branch with fixes and sandbox example/test en route.
Changed in evergreen: | |
assignee: | Bill Erickson (berick) → Galen Charlton (gmc) |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in evergreen: | |
assignee: | nobody → Bill Erickson (berick) |
milestone: | none → 3.4.2 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Branch with fixes for the above and sandbox demo of simplest case grid, with a mix of auto and manual fields and filtering enabled. Includes some IDL 'selector' additions to Action/Trigger classes to bolster the demo code (and to help with bug #1855780).
https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ berick/ lp1858138- grid-filters- link-selectors- misc