Angular grid link selector and filter repairs

[Bill Erickson]

Evergreen 3.4

While diagnosing an issues using grid filters and showLinkSelector, I stumbled on a number of issues in the grid, idl, and combobox code that required some tweaking.

* Grid showLinkSelectors no longer serves any purpose, since the format service (used by the grid) now renders link selector values whenever it can.

* The code which extracts the IDL information on grid fields suffers from an off-by-one issue when stamping the IDL class for a field. E.g. rendering an A/T event definition row, it stamps "hook" with the "ath" class, even though it's a column on an "atevdef" object. In this example, "hook.key" should be stamped as class "ath". In particular, this off-by-one breaks the aforementioned format service link selector rendering.

* IDL field extraction behaves differently for auto fields vs fields declared in the markup.

* Column 'name' should suffice for IDL field data extraction when no 'path' attribute is defined.

* The code that determines the field name of the selector on a linked class could be smarter by only using 'name' as a fallback if such a field exists on the class. It could also be better consolidated into the IDL service.

* Grid filter comboboxes don't respond well to clearing the combobox value (console errors).

* Comboboxes attempt to load async data using _CLICK_ as a search term when clicked and asyncSupportsEmptyTermClick is disabled.

Branch with fixes and sandbox example/test en route.

[Bill Erickson (berick)]

Branch with fixes for the above and sandbox demo of simplest case grid, with a mix of auto and manual fields and filtering enabled. Includes some IDL 'selector' additions to Action/Trigger classes to bolster the demo code (and to help with bug #1855780).

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1858138-grid-filters-link-selectors-misc

[Galen Charlton (gmc)]

Signed pushed to user/gmcharlt/lp1858138_signoff.

The branch includes a couple follow-ups:

- removing current uses of showLinkSelectors
- fleshing a couple more columns for the acp grid in the sandbox so that usrnames are displayed for creator and editor rather than ID.

[Bill Erickson (berick)]

Thanks, Galen!

I applied the new patches and poked a variety of interfaces for breakage and all seems well.

The whole shebang with sign-off's for Galen's commits pushed to rel_3_4 and up.