Angular Local Admin Field Doc Port

[Kyle Huckins]

Evergreen: master

We’ll be porting the Field Documentation UI from DOJO to Angular. The existing UI seems to have some issues on browsers preventing it from fully working as intended, so development will need to base itself more on the code rather than relying on the UI as a guide.

[Kyle Huckins (khuckins)]

I've pushed a branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1857910-field-documentation-angular-port

[Jane Sandberg (sandbergja)]

Thanks for this branch, Kyle. Two quick questions:

1) I saw that your branch maintains a link to the legacy dojo-based interface in the local admin splash page. Is this intentional, or left over from development?

2) Can we take the opportunity to add some human-readable labels for these fields in fm_IDL.xml?

[Lynn Floyd (lfloyd)]

I am adding my support for Human-readable labels for these fields.

[Kyle Huckins (khuckins)]

Thanks for the feedback Jane! The legacy link is leftover from development, must've missed that. Will update this week with the link removed. I'll look into human-readable labels, as well, if it would be better to address them here rather than on a separate branch

[Kyle Huckins (khuckins)]

A bit later than expected, but I've removed the legacy link and rebased. I've also been looking through fm_idl to determine what labels are missing, and it looks like a pretty large task, which may need more eyes than just mine, I'll be filing a launchpad bug with the needsdiscussion tag once I've drafted up a summary of what's missing

[Bill Erickson (berick)]

New branch pushed that fixes 2 issues with the move to Angular 10 and includes sign-off for Kyle's commit.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1857910-ang-field-doc-port

However, I think this branch would benefit from a few additions.

1. A workstation setting "eg.grid.admin.config.idl_field_doc" for persisting the grid columns.

2. Implement a proper gridDataSource.getRows function instead of modifying the data array directly. As a part of this, implement paging and sorting in the data retrieval.

3. Even though the Dojo UI does not have one -- not sure why -- an org filter would be helpful, or better yet an org-family-select input.

[Jason Etheridge (phasefx)]

I've pushed a rebased branch with my signoffs and 4 extra commits (so the top 6 commits) implementing Bill's suggestions for additions and a release notes blurb

collab/phasefx/lp1857910-ang-field-doc-port

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1857910-ang-field-doc-port

[Jane Sandberg (sandbergja)]

This is looking good! Thanks, Kyle, Bill, and Jason! Pushed to master for inclusion in 3.10.

[Galen Charlton (gmc)]

Grabbing this to tidy up a couple things from the merge yesterday.

[Galen Charlton (gmc)]

I've pushed patches to:

- clean up Angular lint
- assign a DB revision number to the update
- enhance the IDL to include labels for the fdoc fields and specify required fields there
- fix a styling issue related to the class and field being mandatory that affects Firefox

[Jane Sandberg (sandbergja)]

Guess I'm a little rusty! Thanks so much, Galen, for catching these and doing the cleanup!